Subject: Re: jsonpath
To: Alexander Korotkov <a.korotkov@postgrespro.ru>,
 Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: Oleg Bartunov <obartunov@postgrespro.ru>,
 Michael Paquier <michael@paquier.xyz>,
 Stas Kelvich <s.kelvich@postgrespro.ru>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Thomas Munro <thomas.munro@enterprisedb.com>,
 David Steele <david@pgmasters.net>, Tom Lane <tgl@sss.pgh.pa.us>,
 Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
 Robert Haas <robertmhaas@gmail.com>, Pavel Stehule <pavel.stehule@gmail.com>
References: 
 <CAA8=A796mY7kJdKARt7B+faW70-c8mRh+Ff_joBJ+NyCFLv3Gg@mail.gmail.com>
 <CAPpHfdtYvffCJfChnFMcOOP6O0RgJVkXy1-_1=teFc8aRJUY7g@mail.gmail.com>
 <CAPpHfdtq0b_g9MmDPpAOFkxXSH93TrJCkxNc5EmJktUJ0tuZtA@mail.gmail.com>
 <CAPpHfdtcO+VCoKTMpSUL9LVzqHv7uthi-jAdzYTxaHc1+h6fVQ@mail.gmail.com>
 <CAPpHfdsd77VeSwrNhaf8FMUUjABqYWKaJUr+ch-0gxMObV02Hg@mail.gmail.com>
 <CAF4Au4x8wELTcwu0XS9nSZwNfJEFitNjU=_M=1WzHtdBPkwVpw@mail.gmail.com>
 <CAPpHfdtQP7th_ui9gV3ih4mDCP2kfdw6sJ2YZY4WwPvp1NQEUA@mail.gmail.com>
 <CAPpHfdv2bro1224314aRijKJu1bfwEimKr6hExoOaF4sqSDTQA@mail.gmail.com>
 <CAF4Au4zTZ18j_7Q4VeiJvJ3egJkEQtu7MfgU_ADp5pYVbdnkpA@mail.gmail.com>
 <264a6413-7175-9680-b976-d50392c001c0@postgrespro.ru>
 <CAPpHfdtxOuEu4t-uGwJF9qzusAmViBf_e3cLYUx1mEoqwWD21g@mail.gmail.com>
 <CAPpHfdu4nKqccH0tE84fTJqc7qV-9_w_uic1_zGTYY4FEbQUOw@mail.gmail.com>
 <CAPpHfduk=0DOKa40A+0Gi-eo03on_7DZgLZV9vNGdgfUMF_v2w@mail.gmail.com>
 <CAPpHfdv+YtPtmircv0kDNH8t9CJ2u8NVGT0JMOxxG2Tdi9BAYg@mail.gmail.com>
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Message-ID: <eebc218c-7aaa-c425-6ba0-78b28c751830@2ndquadrant.com>
Date: Mon, 28 Jan 2019 14:50:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: 
 <CAPpHfdv+YtPtmircv0kDNH8t9CJ2u8NVGT0JMOxxG2Tdi9BAYg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/28/19 1:22 AM, Alexander Korotkov wrote:
> On Sun, Jan 27, 2019 at 1:50 PM Alexander Korotkov
> <a.korotkov@postgrespro.ru> wrote:
>> On Sat, Jan 26, 2019 at 4:27 AM Alexander Korotkov
>> <a.korotkov@postgrespro.ru> wrote:
>>>
>>> On Wed, Jan 23, 2019 at 8:01 AM Alexander Korotkov
>>> <a.korotkov@postgrespro.ru> wrote:
>>>> Finally, I'm going to commit this if no objections.
>>>
>>> BTW, I decided to postpone commit for few days.  Nikita and me are
>>> still working on better error messages.
>>
>> Updated patchset is attached.  This patchset includes:
>>
>> * Improved error handling by Nikita, revised by me,
>> * Code beautification.
>>
>> So, I'm going to commit this again.  This time seriously :)
> 
> I'm really sorry for confusing people, but I've one more revision.
> This is my first time attempting to commit such a large patch.
> 

I'm not sure what you're apologizing for, it simply shows how careful
you are when polishing such a large patch.

> Major changes are following:
>  * We find it ridiculous to save ErrorData for possible latter throw.
> Now, we either throw an error immediately or return jperError.  That
> also allows to get rid of unwanted changes in elog.c/elog.h.

OK.

>  * I decided to change behavior of jsonb_path_match() to throw as less
> errors as possible.  The reason is that it's used to implement
> potentially (patch is pending) indexable operator.  Index scan is not
> always capable to throw as many errors and sequential scan.  So, it's
> better to not introduce extra possible index scan and sequential scan
> results divergence.
> 

Hmmm, can you elaborate a bit more? Which errors were thrown before and
are not thrown with the current patch version?

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services