Subject: Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.
To: James Hilliard <james.hilliard1@gmail.com>,
 pgsql-hackers@lists.postgresql.org
Cc: Sergey Shinderuk <s.shinderuk@postgrespro.ru>,
 Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
References: <20210122193230.25295-1-james.hilliard1@gmail.com>
 <CADvTj4pZy=BNW00dtOA5LTBDiSMo2bXaea_gh8UQSLOsn+mRNQ@mail.gmail.com>
From: David Steele <david@pgmasters.net>
Message-ID: <ef0dbb86-511d-94a0-de54-ce526c505a4a@pgmasters.net>
Date: Mon, 29 Mar 2021 09:52:10 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: 
 <CADvTj4pZy=BNW00dtOA5LTBDiSMo2bXaea_gh8UQSLOsn+mRNQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/ef0dbb86-511d-94a0-de54-ce526c505a4a%40pgmasters.net>
Precedence: bulk

Hi James,

On 1/31/21 1:59 AM, James Hilliard wrote:
> On Fri, Jan 22, 2021 at 12:32 PM James Hilliard
> <james.hilliard1@gmail.com> wrote:
>>
>> Fixes:
>> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -O2 -I../../../../src/include  -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk    -c -o fd.o fd.c
>> fd.c:3661:10: warning: 'pwritev' is only available on macOS 11.0 or newer [-Wunguarded-availability-new]
>>                  part = pg_pwritev(fd, iov, iovcnt, offset);
>>                         ^~~~~~~~~~

It would be better to provide this patch as an attachment so the cfbot 
(http://commitfest.cputube.org/) can test it.

Regards,
-- 
-David
david@pgmasters.net