public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrew Dunstan <[email protected]>
To: Andres Freund <[email protected]>
To: Thomas Munro <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: Prefetch data referenced by the WAL, take II.
Date: Thu, 7 Apr 2022 08:18:05 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>


On 4/7/22 04:36, Andres Freund wrote:
> Hi,
>
> On 2022-04-07 07:44:20 +0000, Thomas Munro wrote:
>> Prefetch data referenced by the WAL, take II.
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-04-07%2008%3A17%3A27
> thinks that xlogpretcher.h doesn't include enough...
>
> I had added those checks to CI, but apparently somehow screwed that up.
>
> Or maybe it's the scripts that are screwed up? Because I don't see any error
> checking in headerscheck/cpluspluscheck. And indeed, locally they show the
> errors, but exit with 0.


Yeah, you can't rely on the exit status, if they produce output that
should be regarded as a failure (that's what crake does).


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: Prefetch data referenced by the WAL, take II.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox