MIME-Version: 1.0
Date: Mon, 21 Nov 2022 17:44:22 +0300
From: Alexander Pyhalov <a.pyhalov@postgrespro.ru>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@lists.postgresql.org, Masahiko Sawada
 <sawada.mshk@gmail.com>, Michael Paquier <michael@paquier.xyz>,
 =?UTF-8?Q?=E6=9D=8E=E6=9D=B0=28=E6=85=8E=E8=BF=BD=29?=
 <adger.lj@alibaba-inc.com>, =?UTF-8?Q?=E6=9B=BE=E6=96=87=E6=97=8C=28?=
 =?UTF-8?Q?=E4=B9=89=E4=BB=8E=29?= <wenjing.zwj@alibaba-inc.com>, Alvaro
 Herrera <alvherre@2ndquadrant.com>
Subject: Re: CREATE INDEX CONCURRENTLY on partitioned index
In-Reply-To: <20221121030011.GU11463@telsasoft.com>
References: <20201031063117.GF3080@telsasoft.com>
 <20201129202221.GA9477@telsasoft.com>
 <CAD21AoCHYE5=PU7kJGGUHZuYVrHTHqmpUxN+8-rLGYpdgPwJ9g@mail.gmail.com>
 <20210128143013.GC7450@telsasoft.com>
 <be8ff634-72c6-3fc7-9175-5a6b974af4a9@postgrespro.ru>
 <20210226182019.GU20769@telsasoft.com>
 <04657227cc37b6353cf0c72bedac70cc@postgrespro.ru>
 <20220628183309.GD28130@telsasoft.com>
 <bec008ae632d54b3d81af2ca86419732@postgrespro.ru>
 <20221121030011.GU11463@telsasoft.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <ef4a974deb26d1865e86eb46f17876f2@postgrespro.ru>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/ef4a974deb26d1865e86eb46f17876f2%40postgrespro.ru>
Precedence: bulk

Justin Pryzby писал 2022-11-21 06:00:
> I finally found time to digest and integrate your changes into my local
> branch.  This fixes the three issues you reported: FORCE_RELEASE, issue
> with INVALID partitions issue (for which I adapted your patch into an
> earlier patch in my series), and progress reporting.  And rebased.

Hi.

Thank you for the effort.
I've looked through and tested new patch a bit. Overall it looks good to 
me.
The question I have is whether we should update 
pg_stat_progress_create_index in reindex_invalid_child_indexes(), when 
we skip valid indexes?
-- 
Best regards,
Alexander Pyhalov,
Postgres Professional