public inbox for [email protected]
help / color / mirror / Atom feedFrom: Euler Taveira <[email protected]>
To: Amit Kapila <[email protected]>
To: Peter Smith <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Greg Nancarrow <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Ajin Cherian <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Dilip Kumar <[email protected]>
Cc: Rahila Syed <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Önder Kalacı <[email protected]>
Cc: japin <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: David Steele <[email protected]>
Cc: Craig Ringer <[email protected]>
Cc: Amit Langote <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: row filtering for logical replication
Date: Thu, 06 Jan 2022 10:11:56 -0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA4eK1KyiBPVOzvzpB9LEMnD2fPAGyU_SXaup0WG=mxuGV=Hnw@mail.gmail.com>
References: <CAHut+Pv4os_ZtB4uJE6hi_Kp4px6e3WtPTX-7eTK9YJicqq1Cw@mail.gmail.com>
<CAHut+PsUe3+crzQF_Ljivp5UgxkuEMBM76K=M+8fp41rXb-46Q@mail.gmail.com>
<OS0PR01MB5716A7ADC776818C5C6F334494429@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<OS0PR01MB571620801232D197AFC1F2C394429@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<TYAPR01MB57240C054D95F0AE55618D2C94439@TYAPR01MB5724.jpnprd01.prod.outlook.com>
<CAA4eK1J=G4t=e+4a=+qFx5QHpF41ce=2tD_ACMhtMJPzqBknUQ@mail.gmail.com>
<CAA4eK1Ky0z=+UznCUHOs--L=Es_EMmZ_rxNo8FH73=758sahsQ@mail.gmail.com>
<CAHut+PsjMh1fkYsAWqJsd_Ks=d0-CwUyp5rMYQf6kzOfyZUYhw@mail.gmail.com>
<CAA4eK1KyiBPVOzvzpB9LEMnD2fPAGyU_SXaup0WG=mxuGV=Hnw@mail.gmail.com>
On Thu, Jan 6, 2022, at 1:18 AM, Amit Kapila wrote:
> On Thu, Jan 6, 2022 at 8:43 AM Peter Smith <[email protected]> wrote:
> >
> > On Wed, Jan 5, 2022 at 9:52 PM Amit Kapila <[email protected]> wrote:
> > >
> > ...
> >
> > > Another minor comment:
> > > +static bool pgoutput_row_filter(enum ReorderBufferChangeType changetype,
> > >
> > > Do we need to specify the 'enum' type before changetype parameter?
> > >
> >
> > That is because there is currently no typedef for the enum
> > ReorderBufferChangeType.
> >
>
> But I see that the 0002 patch is already adding the required typedef.
IMO we shouldn't reuse ReorderBufferChangeType. For a long-term solution, it is
fragile. ReorderBufferChangeType has values that do not matter for row filter
and it relies on the fact that REORDER_BUFFER_CHANGE_INSERT,
REORDER_BUFFER_CHANGE_UPDATE and REORDER_BUFFER_CHANGE_DELETE are the first 3
values from the enum, otherwise, it breaks rfnodes and no_filters in
pgoutput_row_filter(). I suggest a separate enum that contains only these 3
values.
enum RowFilterPublishAction {
PUBLISH_ACTION_INSERT,
PUBLISH_ACTION_UPDATE,
PUBLISH_ACTION_DELETE
};
--
Euler Taveira
EDB https://www.enterprisedb.com/
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: row filtering for logical replication
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox