Message-ID: <ef71c2b7-dd1c-4321-b223-09c4efbfc3ae@gmail.com>
Date: Mon, 31 Mar 2025 08:24:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Proposal: Progressive explain
To: torikoshia <torikoshia@oss.nttdata.com>,
 Rafael Thofehrn Castro <rafaelthca@gmail.com>, robertmhaas@gmail.com
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: 
 <CAG0ozMpD27fCyVFoa82G7uV4md4wVYw7DWC-PVA6P5=1v35tsA@mail.gmail.com>
 <CAG0ozMpjEFThDGNqSoFTj1v_cpEs0rRQw5moVKU6Oy88oQ=Yhw@mail.gmail.com>
 <CA+TgmoZ51Hc7o_vFo8rbPqkLpSVzH6i=ccPrt2mHBPyk=zMxwQ@mail.gmail.com>
 <CAG0ozMq48+ODFoLW4HHexN8BKHfh_4c-n2b=yH9oaUnCZNZj6Q@mail.gmail.com>
 <4be5223e-4725-49a2-b49f-769f4f402984@gmail.com>
 <CAG0ozMpPhK1L5eUBq-FJU+uYTPoJ-EPfhPAHpyJvtJpBJHTcvQ@mail.gmail.com>
 <CA+TgmoY0hj+P68iB_JrVMoEV4mbAKthiY2i36ksgFPfU7i80SQ@mail.gmail.com>
 <CAG0ozMo=quwiEfU40n94NGqxB4DydKxNWyeD6U2OX68Z9RhSbg@mail.gmail.com>
 <CA+TgmobGZseEpTeyhzstFs6rVKaB-_CfiC7gTuvz=QhWc=aR=w@mail.gmail.com>
 <CAG0ozMovsrnnLGEM6h0puBr-ihLjYDp11kvnCrnym3D28BZ7eg@mail.gmail.com>
 <CAG0ozMo2HQjmpn9AHGXOo726-PgH=+XmkoPUVxAqvcOS6puq8g@mail.gmail.com>
 <CA+Tgmobjnj0FJj-0GUSXCga3-mUe819Wj=EeZqY=QydMWGOguA@mail.gmail.com>
 <CAG0ozMpug5icxk8Mh_uiGc3OX3zsx67RsRA9Q-o+3ZXn-7M9mQ@mail.gmail.com>
 <b67d2e9406bc307798170a21dfefe467@oss.nttdata.com>
Content-Language: en-AU
From: Andrei Lepikhov <lepihov@gmail.com>
In-Reply-To: <b67d2e9406bc307798170a21dfefe467@oss.nttdata.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/ef71c2b7-dd1c-4321-b223-09c4efbfc3ae%40gmail.com>
Precedence: bulk

On 3/31/25 02:23, torikoshia wrote:
> On Fri, Mar 7, 2025 at 6:43 AM Rafael Thofehrn Castro 
>> Implemented this version. New patch has the following characteristics:
> 
> 
> I haven't looked into the code yet, but when I ran below commands during 
> make installcheck, there was an error and an assertion failure
> 
>    =# select * from pg_stat_progress_explain;
>    =# \watch 0.1
Yeah, that's to be expected.
I think many corner cases may be found: hash table in the middle of 
filling, opened file descriptors, an incorrect combination of variables, 
  'not yet visited' subtrees - who knows what else? So, last time, I 
just ended up with the idea that using the explain code is a bit 
dangerous - in the middle of execution, it is enough to expose only 
basic data - rows, numbers and timings. It seems safe to gather.

-- 
regards, Andrei Lepikhov