Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u4y7U-00ABtV-6W for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Apr 2025 08:27:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u4y7R-009emq-5L for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Apr 2025 08:27:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u4y7Q-009elK-Qa for pgsql-hackers@lists.postgresql.org; Wed, 16 Apr 2025 08:27:41 +0000 Received: from air.basealt.ru ([193.43.8.18]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u4y7O-000MUo-1B for pgsql-hackers@lists.postgresql.org; Wed, 16 Apr 2025 08:27:41 +0000 Received: from [10.4.129.65] (unknown [193.43.10.250]) (Authenticated sender: kuznetsovam) by air.basealt.ru (Postfix) with ESMTPSA id 34DAA233AC; Wed, 16 Apr 2025 11:27:38 +0300 (MSK) Content-Type: multipart/mixed; boundary="------------IiQJjwYv0jnRQXnUuNx4LKHv" Message-ID: Date: Wed, 16 Apr 2025 11:27:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: PostgreSQL Developers Cc: egori@altlinux.org, nickel@altlinux.org Reply-To: kuznetsovam@altlinux.org From: Alexander Kuznetsov Subject: pg_dump: Fix dangling pointer in EndCompressorZstd() List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------IiQJjwYv0jnRQXnUuNx4LKHv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello everyone, We've found that EndCompressorZstd() doesn't set cs->private_data to NULL after pg_free(), unlike other EndCompressor implementations. While this doesn't currently cause issues (as the pointer soon gets reassigned), we recommend fixing this to maintain consistency with other implementations and prevent potential future issues. The patch is attached, would appreciate your thoughts on this change. -- Best regards, Alexander Kuznetsov --------------IiQJjwYv0jnRQXnUuNx4LKHv Content-Type: text/x-patch; charset=UTF-8; name="0001-pg_dump-Fix-dangling-pointer-in-EndCompressorZstd.patch" Content-Disposition: attachment; filename*0="0001-pg_dump-Fix-dangling-pointer-in-EndCompressorZstd.patch" Content-Transfer-Encoding: base64 RnJvbSA0MjhjNjA4ODhmOTZhYTVkMGI3NTc1YTQzNDJjZGNlNGZmMDI1N2FiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kZXIgS3V6bmV0c292IDxrdXpuZXRzb3Zh bUBhbHRsaW51eC5vcmc+CkRhdGU6IFdlZCwgMTYgQXByIDIwMjUgMTE6MTk6NTYgKzAzMDAK U3ViamVjdDogW1BBVENIXSBwZ19kdW1wOiBGaXggZGFuZ2xpbmcgcG9pbnRlciBpbiBFbmRD b21wcmVzc29yWnN0ZCgpCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9w bGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0Cgpj cy0+cHJpdmF0ZV9kYXRhIGJlY29tZXMgZGFuZ2xpbmcgYWZ0ZXIgcGdfZnJlZSgpIGNhbGwg YW5kIHNob3VsZCBiZSBzZXQgdG8gTlVMTAooY29uc2lzdGVudCB3aXRoIG90aGVywqBFbmRD b21wcmVzc29ywqBpbXBsZW1lbnRhdGlvbnMpCgpGb3VuZCBieSBMaW51eCBWZXJpZmljYXRp b24gQ2VudGVyIChsaW51eHRlc3Rpbmcub3JnKSB3aXRoIFN2YWNlLgotLS0KIHNyYy9iaW4v cGdfZHVtcC9jb21wcmVzc196c3RkLmMgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2Vy dGlvbigrKQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfZHVtcC9jb21wcmVzc196c3RkLmMg Yi9zcmMvYmluL3BnX2R1bXAvY29tcHJlc3NfenN0ZC5jCmluZGV4IDFmN2I0OTQyNzA2Li5j YjU5NWIxMGMyZCAxMDA2NDQKLS0tIGEvc3JjL2Jpbi9wZ19kdW1wL2NvbXByZXNzX3pzdGQu YworKysgYi9zcmMvYmluL3BnX2R1bXAvY29tcHJlc3NfenN0ZC5jCkBAIC0xNDIsNiArMTQy LDcgQEAgRW5kQ29tcHJlc3NvclpzdGQoQXJjaGl2ZUhhbmRsZSAqQUgsIENvbXByZXNzb3JT dGF0ZSAqY3MpCiAJLyogb3V0cHV0IGJ1ZmZlciBtYXkgYmUgYWxsb2NhdGVkIGluIGVpdGhl ciBtb2RlICovCiAJcGdfZnJlZSh6c3RkY3MtPm91dHB1dC5kc3QpOwogCXBnX2ZyZWUoenN0 ZGNzKTsKKwljcy0+cHJpdmF0ZV9kYXRhID0gTlVMTDsKIH0KIAogc3RhdGljIHZvaWQKLS0g CjIuNDIuNAoK --------------IiQJjwYv0jnRQXnUuNx4LKHv--