public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: Jeff Davis <[email protected]>
Cc: [email protected]
Subject: Re: Refactor: allow pg_strncoll(), etc., to accept -1 length for NUL-terminated cstrings.
Date: Thu, 14 May 2026 18:17:17 -0400
Message-ID: <ej6fxlbyqwu6hflotvghgzowdgkeekw2up6ucyhrbbfheibtq4@uk42gkxu76s7> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<s32n3tm2mjh247f3xkkxkdk7cf77hglbr3ia3hrsdjylajou7y@nlldpag3tjd5>
	<[email protected]>

Hi,

On 2026-05-05 13:23:12 -0700, Jeff Davis wrote:
> Agreed. I did this to match up with the ICU API a bit better, but if
> it's interfering with useful tools, then the special cases aren't worth
> it.

> Patch attached.

Thanks!


> It causes a bit of churn, so one disadvantage is that it will complicate
> future backports in this area.

I think it's worth the gain in instrument-ability.  I also suspect it's good
for runtime performance, adding all those branches can't be particularly good.


Greetings,

Andres Freund

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Refactor: allow pg_strncoll(), etc., to accept -1 length for NUL-terminated cstrings.
  In-Reply-To: <ej6fxlbyqwu6hflotvghgzowdgkeekw2up6ucyhrbbfheibtq4@uk42gkxu76s7>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox