Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vTetW-006iJ9-36 for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Dec 2025 11:31:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vTetU-003Su4-2D for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Dec 2025 11:31:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vTetU-003Stv-18 for pgsql-hackers@lists.postgresql.org; Thu, 11 Dec 2025 11:31:37 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vTetT-0008Sr-1q for pgsql-hackers@lists.postgresql.org; Thu, 11 Dec 2025 11:31:36 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-42b47f662a0so1000655f8f.0 for ; Thu, 11 Dec 2025 03:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec.at; s=google; t=1765452693; x=1766057493; darn=lists.postgresql.org; h=content-transfer-encoding:mime-version:user-agent:reply-to :references:in-reply-to:message-id:date:cc:subject:to:from:from:to :cc:subject:date:message-id:reply-to; bh=W5+dcS0OVxRSaRX3oajin7UA/kgoNo8qOVFsZW39ll4=; b=G351X0dqIKI3n54+JBmz2XNQgmaD7zYlW9ftM2Y0x0kbQUoR5NPL4SVm62M093ULL/ NW9HLzgWBMVukDMVkhUIsCGHh4doXIIJNAAWyX0cWM7jPMZkditL/Wr/ez9qoNuAHY6O Y0aSabrpT9fSUU+cPpQL72gP/cvecBVyg5DDQI4FPcjeTLUO7KlWAyYL8nSUqjQQK/Fi pB9dUGflpfDAD8+hQHkz/nisfn0Q+ib6P3laIBQXv+R3Pclwp8Px7DCbjQrG9q2rVvG4 kVSBCSidIk+W0NFLJ65UPXLbtLJrrsgVb/TyL6HbC1PsIu4dkqL0G8p79s9yMjPN7w5V nKaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765452693; x=1766057493; h=content-transfer-encoding:mime-version:user-agent:reply-to :references:in-reply-to:message-id:date:cc:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W5+dcS0OVxRSaRX3oajin7UA/kgoNo8qOVFsZW39ll4=; b=NWce3So2WuOqx9Pg0L+erEPu/fxnCc9YTHdPz6TTEYrPF1TWAKya1YhKOHH3Kux+U9 k/LcnjLHY0nz7o+MWdd0oiPaeA3KJsHBtFE/PGVw29Y3v18d1NZN+oJz6h2IDcSmb87p YBYCMLkfRtZMjutM9Ng3qSR7EdN5oZ9+82UriFVKKOpA+zxdEq06bcJG4nlMu7ZclKXe aK8ywcXIsWUIiUQlCYxs0YWu8P7O2vuek5yshYJMEmxOpQuO8lYpXSP9eY6vkAB7UJZk Z2Chr4SVOZeGa3oytimuUbeFgqxVVGrLuH4TwUhWce+QBxCRrLOgzGrjkObDjM22UFJa CrGw== X-Gm-Message-State: AOJu0YzEKsEIu9G90UN2zfT6NEDvP+tdFRy4PagxgtfjMDass0r2LGTc a92KW93vLRpHliM4PPvGC4t7tVqaRImCaf6X1BLZbFJ3/ppC1mTl2efjlhKva7nXVxw= X-Gm-Gg: AY/fxX7xE3Z8I5QaoZ2GXDjjdj7jAxpxCfdm/X9XeV/9d7druec7tEZPee+Yj8OmzCz +U8Kh7ttPB5UC5YXBfXOmhq2xUbxZa4Fa/5INpxS5Poj89lvVk67YIL90wojYR+wUCaSjWVXfQ6 vRN0XDGor2dJ5BXFGxDNj57tOL/o8YHnbFj5Bn/qHt3mhP15m7RtQvJHy70YzGMcI+HKSPnPUaG PaklfNhOIc7RgvTPxOHGK88FmzdGt1l8brvzJtZDrYQl6Wa3Gv7uvNIk2tFr1BgjGTSplHtz+e7 HJZWN1+Suru32wm92GJ+Q9jCrZ71T/fi+nZIPRrojl3J56Zo9Y3AYR9+jwp9OqtsmvfjyjGq+Hg eOHYWPSXQlm9MHJSDd6s7vsw4hmmqvxZVasXLYrCwYW0kARtXWN5wnyZIsc6Dyx+vkDQhYz3mjm PAMpWWj+ng0QbCTDqKMXBxXe4nQPjktNiIhGNrsHttRWKcnG9KUz1XvJNJe2Up X-Google-Smtp-Source: AGHT+IFBixpEUzpQ4E1398DA9BU/qfGIurxQvZZ1J0WzLOe0JMMfF+KAPZM1iScRxKeRko0z5c5raA== X-Received: by 2002:a5d:5f88:0:b0:42f:8817:7ee with SMTP id ffacd0b85a97d-42fab28c9b3mr2379316f8f.31.1765452693511; Thu, 11 Dec 2025 03:31:33 -0800 (PST) Received: from ?IPv6:::ffff:192.168.0.101? ([62.197.243.85]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42fa8a6671asm5659205f8f.1.2025.12.11.03.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 03:31:33 -0800 (PST) From: "Pavlo Golub" To: "Sami Imseih" Subject: Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements Cc: pgsql-hackers@lists.postgresql.org Date: Thu, 11 Dec 2025 11:31:39 +0000 Message-Id: In-Reply-To: References: Reply-To: "Pavlo Golub" User-Agent: eM_Client/10.3.2619.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi >Hi, > >Thanks for raising this. I did not look at the patch, but I have some high >level comments. > >> I would like to propose adding a last_executed timestamptz column to >> pg_stat_statements. This column records when each tracked statement >> was most recently executed. > >I do think there is value in adding a last_executed timestamp. Thanks for your support! >Can pg_stat_statements.stats_since help here? > >for example "where stats_since > last_poll_timestamp" ? Actually no, monitoring tools fetch snapshots to find the difference=20 between snapshots. Data for every statement is changes after each execution. But stats_since is inserted only once when the new statement execution=20 appears and is never updated during next executions. > > >The client does have to track the last_poll_timestamp in that >case. > >[0] https://www.postgresql.org/message-id/flat/CAA5RZ0s9SDOu+Z6veoJCHWk+kD= eTktAtC-KY9fQ9Z6BJdDUirQ@mail.gmail.com >[1] https://www.postgresql.org/message-id/03f82e6f-66a3-4c4d-935c-ea4d9387= 1dc1%40gmail.com > >-- >Sami Imseih >Amazon Web Services (AWS)