From: "Pavlo Golub" <pavlo.golub@cybertec.at>
To: "Sami Imseih" <samimseih@gmail.com>
Subject: Re[4]: [PATCH] Add last_executed timestamp to pg_stat_statements
Cc: "Bertrand Drouvot" <bertranddrouvot.pg@gmail.com>, "Christoph Berg"
 <myon@debian.org>, "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>
Date: Fri, 06 Feb 2026 10:44:58 +0000
Message-Id: <emed32d635-e46b-4f08-9085-3fd822fe5765@cybertec.at>
In-Reply-To: <CAA5RZ0u_jjiLc_w4nksdVazvvqtE17C1nM=sKf9fy5x02orfsg@mail.gmail.com>
References: <CAK7ymc+FxoVswo1ok_xDW-xPG-ZEZ8SAqCUkJ7WF04=0aQDvVQ@mail.gmail.com>
 <CAA5RZ0uyvnNuHRj=73jZhocnLxE07oM-AeSLS=FUuuZ_hy7fKA@mail.gmail.com>
 <em5be966c3-9086-4f3f-b516-97444b854fdf@10e48d49.com>
 <CAA5RZ0u6qdcLoWJJz5mUB_VYZqT__U-HJJ5_ioYO7XGsUfXfpw@mail.gmail.com>
 <aYIh7I9khvoewwH_@msg.df7cb.de>
 <CAA5RZ0tH_+3JGMCktkp8EMyvKaRAJf-xRh+y_UoZ8azvuUEAYQ@mail.gmail.com>
 <aYMKolTlvzenr4Pk@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAK7ymc+E00zKC9Da+BK2se=O2RiOUkdW5dz4iAynD1Vj=Pwexg@mail.gmail.com>
 <CAA5RZ0u_jjiLc_w4nksdVazvvqtE17C1nM=sKf9fy5x02orfsg@mail.gmail.com>
Reply-To: "Pavlo Golub" <pavlo.golub@cybertec.at>
User-Agent: eM_Client/10.4.4209.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/emed32d635-e46b-4f08-9085-3fd822fe5765%40cybertec.at>
Precedence: bulk

Hey

>>  Thank you to Sami, Christoph, and Bertrand for the thorough review and=
 valuable
>>  feedback on v1. I've prepared a v2 patch that addresses all the concern=
s raised.
>
>Thanks for the patch! I have not looked at v2 in detail yet. Did take
>a quick peek
>at the doc. Some comments:
>
>>  I've renamed the column to `stats_last_updated` as Christoph suggested. =
This
>>  matches the existing "stats_since" column for consistency. Following Ch=
ristoph's
>>  suggestion, I've also moved it to the end of the view.
>
>I still wonder if "stats_last_updated" is a good name here. What about
>"last_execution_start", since that is exactly what this timestamp is.

Yeah, sounds better really. Thanks

>
>
>+ <entry role=3D"catalog_table_entry"><para role=3D"column_definition">
>+ <structfield>stats_last_updated</structfield> <type>timestamp with
>time zone</type>
>+ </para>
>+ <para>
>+ Time at which the statement statistics were last updated (specifically,
>+ the time when the statement most recently started execution).
>
>Here I think we can just say:
>
>"The start time of the most recent execution of the statement that complet=
ed. "

+1

>
>
>+ This is useful for monitoring tools to identify which statements
>+ have been executed since their last poll.
>
>I am not sure we need this part for the docs. others may disagree.

Agree, too much details.

>
>
>+ For nested statements (when <varname>pg_stat_statements.track</varname>
>+ is set to <literal>all</literal>), this reflects the start time of the
>+ parent top-level statement.
>+ </para></entry>
>
>Maybe this is better as it mentioned "toplevel"
>
>"For nested statements (toplevel =3D false), this reflects the start time
>of the top-level statement."

I like it. Looks easier to read.

>
>
>what do you think?

Thanks, I'll prepare updated patch
>
>
>--
>Sami Imseih
>Amazon Web Services (AWS)