Feedback-ID: ie0a040ee:Fastmail
Message-ID: <f013ba17-82e6-48c9-b29b-cb0e274e2d37@eisentraut.org>
Date: Fri, 27 Mar 2026 17:08:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Provide support for trailing commas
To: Greg Sabino Mullane <htamfids@gmail.com>
Cc: "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>
References: 
 <CAKAnmmKVwP=yr8t8p8_QtrBFjyENLZyPxscJh4UrkCeqMQuhrw@mail.gmail.com>
 <4042a046-3dc9-4fc6-bfc6-62beb8492f27@eisentraut.org>
 <2228785.1769016115@sss.pgh.pa.us>
 <CAKAnmmK+1Rxv3FSKCku=ePNcwkcd6fqZ5C=y7_3wjyd4+BbwhQ@mail.gmail.com>
 <ab27a660-72b4-41b6-9279-2f007e065fed@eisentraut.org>
 <CAKAnmmKWEffLVRRSYkqKMKoK6RoZc1ecT_rPzMkVsuqOgzbjog@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAKAnmmKWEffLVRRSYkqKMKoK6RoZc1ecT_rPzMkVsuqOgzbjog@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/f013ba17-82e6-48c9-b29b-cb0e274e2d37%40eisentraut.org>
Precedence: bulk

On 23.03.26 23:54, Greg Sabino Mullane wrote:
> Alright, I walked through the entire list of every place the original 
> patch added a comma, and ruthlessly trimmed out the ones that were not 
> really needed, likely to cause issues, and/or frankly applied on too 
> trivial a piece of SQL to worry about. Here's my list that people can 
> poke at. Once we settle on which ones survive, I can make a new patch. 
> The focus is mostly on the largest potential uses: lists of select 
> items / column names.

I wrote:

 > I think there is consensus for allowing a trailing comma in the 
SELECT > list.  This would be the target_list production in gram.y.

I think that's the only one there is consensus about.

(But target_list is also used in RETURNING, so maybe the productions 
would need to be split up.)