Subject: Re: SLRU statistics
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
 "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <20200229122441.ow7gnnqgesmojyc3@development>
 <20200229144426.GA32500@alvherre.pgsql>
 <20200229205518.xrxo535zgd7cl6no@development>
 <20200327004111.md4suoi6u5suv2qe@development>
 <20200328002630.2nz5y3dvymqnvxtv@development>
 <20200402004136.wodwftan45mcwggm@development>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <f02fd0ec-a240-b5bf-9992-5faf582738f1@oss.nttdata.com>
Date: Fri, 1 May 2020 03:02:59 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200402004136.wodwftan45mcwggm@development>
Content-Type: multipart/mixed;
 boundary="------------34AE2DF15D5747A75FAE82D8"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------34AE2DF15D5747A75FAE82D8
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2020/04/02 9:41, Tomas Vondra wrote:
> Hi,
> 
> I've pushed this after some minor cleanup and improvements.

+static char *slru_names[] = {"async", "clog", "commit_timestamp",
+							  "multixact_offset", "multixact_member",
+							  "oldserxid", "pg_xact", "subtrans",
+							  "other" /* has to be last */};

When I tried pg_stat_slru, I found that it returns a row for "pg_xact".
But since there is no "pg_xact" slru ("clog" slru exists instead),
"pg_xact" should be removed? Patch attached.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

--------------34AE2DF15D5747A75FAE82D8
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="remove_pg_xact_from_pg_stat_slru.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="remove_pg_xact_from_pg_stat_slru.patch"

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwgYi9kb2Mvc3JjL3Nn
bWwvbW9uaXRvcmluZy5zZ21sCmluZGV4IDY1NjJjYzQwMGIuLmJhNmQ4ZDIxMjMgMTAwNjQ0
Ci0tLSBhL2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21s
L21vbml0b3Jpbmcuc2dtbApAQCAtMzQ4Myw3ICszNDgzLDcgQEAgU0VMRUNUIHBpZCwgd2Fp
dF9ldmVudF90eXBlLCB3YWl0X2V2ZW50IEZST00gcGdfc3RhdF9hY3Rpdml0eSBXSEVSRSB3
YWl0X2V2ZW50IGkKICAgICAgICBwcmVkZWZpbmVkIGxpc3QgKDxsaXRlcmFsPmFzeW5jPC9s
aXRlcmFsPiwgPGxpdGVyYWw+Y2xvZzwvbGl0ZXJhbD4sCiAgICAgICAgPGxpdGVyYWw+Y29t
bWl0X3RpbWVzdGFtcDwvbGl0ZXJhbD4sIDxsaXRlcmFsPm11bHRpeGFjdF9vZmZzZXQ8L2xp
dGVyYWw+LAogICAgICAgIDxsaXRlcmFsPm11bHRpeGFjdF9tZW1iZXI8L2xpdGVyYWw+LCA8
bGl0ZXJhbD5vbGRzZXJ4aWQ8L2xpdGVyYWw+LAotICAgICAgIDxsaXRlcmFsPnBnX3hhY3Q8
L2xpdGVyYWw+LCA8bGl0ZXJhbD5zdWJ0cmFuczwvbGl0ZXJhbD4gYW5kCisgICAgICAgPGxp
dGVyYWw+c3VidHJhbnM8L2xpdGVyYWw+IGFuZAogICAgICAgIDxsaXRlcmFsPm90aGVyPC9s
aXRlcmFsPikgcmVzZXRzIGNvdW50ZXJzIGZvciBvbmx5IHRoYXQgZW50cnkuCiAgICAgICAg
TmFtZXMgbm90IGluY2x1ZGVkIGluIHRoaXMgbGlzdCBhcmUgdHJlYXRlZCBhcyA8bGl0ZXJh
bD5vdGhlcjwvbGl0ZXJhbD4uCiAgICAgICA8L2VudHJ5PgpkaWZmIC0tZ2l0IGEvc3JjL2Jh
Y2tlbmQvcG9zdG1hc3Rlci9wZ3N0YXQuYyBiL3NyYy9iYWNrZW5kL3Bvc3RtYXN0ZXIvcGdz
dGF0LmMKaW5kZXggNTBlZWEyZThhOC4uMmJhMzg1OGQzMSAxMDA2NDQKLS0tIGEvc3JjL2Jh
Y2tlbmQvcG9zdG1hc3Rlci9wZ3N0YXQuYworKysgYi9zcmMvYmFja2VuZC9wb3N0bWFzdGVy
L3Bnc3RhdC5jCkBAIC0xNTIsNyArMTUyLDcgQEAgUGdTdGF0X01zZ0JnV3JpdGVyIEJnV3Jp
dGVyU3RhdHM7CiAgKi8KIHN0YXRpYyBjaGFyICpzbHJ1X25hbWVzW10gPSB7ImFzeW5jIiwg
ImNsb2ciLCAiY29tbWl0X3RpbWVzdGFtcCIsCiAJCQkJCQkJICAibXVsdGl4YWN0X29mZnNl
dCIsICJtdWx0aXhhY3RfbWVtYmVyIiwKLQkJCQkJCQkgICJvbGRzZXJ4aWQiLCAicGdfeGFj
dCIsICJzdWJ0cmFucyIsCisJCQkJCQkJICAib2xkc2VyeGlkIiwgInN1YnRyYW5zIiwKIAkJ
CQkJCQkgICJvdGhlciIgLyogaGFzIHRvIGJlIGxhc3QgKi99OwogCiAvKiBudW1iZXIgb2Yg
ZWxlbWVuZW50cyBvZiBzbHJ1X25hbWUgYXJyYXkgKi8K
--------------34AE2DF15D5747A75FAE82D8--