Message-ID: <f040113cf384ada69558ec004a04a3ddb3e40a26.camel@j-davis.com>
Subject: Re: Remaining dependency on setlocale()
From: Jeff Davis <pgsql@j-davis.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>, Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-hackers@postgresql.org
Date: Thu, 10 Jul 2025 11:22:50 -0700
In-Reply-To: 
 <CA+hUKGLYcbnHBXhHk_OFwZ03LE+D=cAirm7TVN8fMhT9rgcTbA@mail.gmail.com>
References: <4c5da86af36a0d5e430eee3f60ce5e06f1b5cd34.camel@j-davis.com>
	 <1841102.1722982989@sss.pgh.pa.us>
	 <CA+hUKGK7qKDHgoh1HuvMhtcpAwwVBA5BDt33vCzYYqCLfQTtzw@mail.gmail.com>
	 <CA+hUKGLLTy155HTQ6HfHu5-XPNfoFgDsRVUWevj+O6p3UmvPkg@mail.gmail.com>
	 <a70d3db4b8291b61c6937c0c003aa70e2d2c3a9a.camel@j-davis.com>
	 <CA+hUKGL82jG2PdgfQtwWG+_51TQ--6M9XNa3rtt7ub+S3Pmfsw@mail.gmail.com>
	 <b19ea499a6d78c101dc55b61bfb42069b427445c.camel@j-davis.com>
	 <fa04b56430fa4b5da7311c2faa113f406c6d192a.camel@j-davis.com>
	 <CA+hUKGKcS-Zhi8Ud+tv2TanzXBQjH+WsLyPY9DUDXob5VoYAtg@mail.gmail.com>
	 <cd3517c7-ddb8-454e-9dd5-70e3d84ff6a2@eisentraut.org>
	 <d2e7d63c0cc98f425652527cf260a3e6da17d2b0.camel@j-davis.com>
	 <a1396f17f462ee6561820f755caaf2d12eb9fd15.camel@j-davis.com>
	 <9875f7f9-50f1-4b5d-86fc-ee8b03e8c162@eisentraut.org>
	 <a8666c391dfcabe79868d95f7160eac533ace718.camel@j-davis.com>
	 <6956823dd669abc64183fc91e64dc2e56e31f3ea.camel@j-davis.com>
	 <ed394f839d813762ddcd65cfcab0e062f8b5e0b1.camel@j-davis.com>
	 <CA+hUKGLYcbnHBXhHk_OFwZ03LE+D=cAirm7TVN8fMhT9rgcTbA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.3-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/f040113cf384ada69558ec004a04a3ddb3e40a26.camel%40j-davis.com>
Precedence: bulk

On Thu, 2025-07-10 at 11:53 +1200, Thomas Munro wrote:
> On Thu, Jul 10, 2025 at 10:52=E2=80=AFAM Jeff Davis <pgsql@j-davis.com>
> wrote:
> > The first problem -- how to affect the encoding of strings returned
> > by
> > strerror() on windows -- may be solvable as well. It looks like
> > LC_MESSAGES is not supported at all on windows, so the only thing
> > to be
> > concerned about is the encoding, which is affected by LC_CTYPE. But
> > windows doesn't offer uselocale() or strerror_l(). The only way
> > seems
> > to be to call _configthreadlocale(_ENABLE_PER_THREAD_LOCALE) and
> > then
> > setlocale(LC_CTYPE, datctype) right before strerror(), and switch
> > it
> > back to "C" right afterward. Comments welcome.
>=20
> FWIW there is an example of that in src/port/pg_localeconv_r.c.

OK, so it seems we have a path forward here:

1. Have a global_libc_locale that represents all of the categories, and
keep it up to date with GUC changes. On windows, it requires keeping
the textual locale names handy (e.g. copies of datcollate and
datctype), and building the special locale string and doing
_create_locale(LC_ALL, "LC_ABC=3Dsomelocale;LC_XYZ=3Dotherlocale").

2. When there's no _l() variant of a function, like strerror_r(), wrap
with uselocale(). On windows, this means using the trick above with
_configthreadlocale(_ENABLE_PER_THREAD_LOCALE).

I don't have a great windows development environment, and it appears CI
and the buildfarm don't offer great coverage either. Can I ask for a
volunteer to do the windows side of this work?

Regards,
	Jeff Davis