Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hhzd8-0005rK-Vr for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Jul 2019 16:58:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hhzd7-0007Rt-KG for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Jul 2019 16:58:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hhzd7-0007QJ-87 for pgsql-hackers@lists.postgresql.org; Mon, 01 Jul 2019 16:58:13 +0000 Received: from mail-qt1-f172.google.com ([209.85.160.172]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hhzd4-0007ZI-2j for pgsql-hackers@lists.postgresql.org; Mon, 01 Jul 2019 16:58:11 +0000 Received: by mail-qt1-f172.google.com with SMTP id a15so15365034qtn.7 for ; Mon, 01 Jul 2019 09:58:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=AL8V9JWGRBa9mlOplPSFcGeoLfDveoaewibTBX/2o9E=; b=iFij576uQDXp9esuEYTJw3M7sI9tEesaA5qsPLXGulbSD/X7qPGLLDHYDOQlXkyZyb Ey+Iiwq2YhR4MMDfq05SSxweRkAc8UcbbCuXbB1SqgIRtVH/j/E6J02rOfR4SYXMkAsY OYLYdxj3nWk91w+5kEZEzczWH/xCIWzkLYQUjvZVEiCTIUv+3apLjn+VQvn39vUFSKFW obVrZZ+XEiEPT9aSFQWTP0b0KDZethuVV9rJBM5TcusTy/IWx/wh+mbySstVUl34kb7p MyqGX+0QyakS/1P4GRPlEymBwdR2+7uabWsHO3iTjz+WTvm9pV6j1WZdSG1Gst/FEaKy yvMA== X-Gm-Message-State: APjAAAXHgP0dEtGIQSoS6Fzu7vA/iL57e5C2o9jyIN7SoF7L6dZaP65g qrPL9nHmgW9m18bMznvrfZqiXOYDzcoOuw== X-Google-Smtp-Source: APXvYqz/Gs3EOJSsAEmBevMvC8qKGmSmbr4NuR7+1zbXlVdyuta2oX3GNaXZ+FXNN4EogQSvch1lMQ== X-Received: by 2002:ac8:2194:: with SMTP id 20mr20797029qty.203.1562000288818; Mon, 01 Jul 2019 09:58:08 -0700 (PDT) Received: from localhost.localdomain (c-24-61-8-151.hsd1.ma.comcast.net. [24.61.8.151]) by smtp.gmail.com with ESMTPSA id f68sm5340117qtb.83.2019.07.01.09.58.07 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 01 Jul 2019 09:58:08 -0700 (PDT) Reply-To: jesper.pedersen@redhat.com Subject: Re: POC: converting Lists into arrays To: Tom Lane Cc: David Rowley , Andres Freund , Robert Haas , PostgreSQL Hackers References: <481.1551390571@sss.pgh.pa.us> <24783.1551568303@sss.pgh.pa.us> <20190303043424.itzy3ge52xrkpmpr@alap3.anarazel.de> <437.1551637744@sss.pgh.pa.us> <12684.1551723095@sss.pgh.pa.us> <20190304190612.vgqqsowzkrh22623@alap3.anarazel.de> <26464.1551734920@sss.pgh.pa.us> <20190304221101.hdg4vj5fo4eewh3b@alap3.anarazel.de> <20190304235402.nod3gbotk2qtd4nh@alap3.anarazel.de> <1131.1551746172@sss.pgh.pa.us> <14626.1558745627@sss.pgh.pa.us> <29297.1558799327@sss.pgh.pa.us> From: Jesper Pedersen Organization: Red Hat Message-ID: Date: Mon, 1 Jul 2019 12:58:07 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <29297.1558799327@sss.pgh.pa.us> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi, On 5/25/19 11:48 AM, Tom Lane wrote: > The cfbot noticed a set-but-not-used variable that my compiler hadn't > whined about. Here's a v5 to pacify it. No other changes. > This needs a rebase. After that check-world passes w/ and w/o -DDEBUG_LIST_MEMORY_USAGE. There is some unneeded MemoryContext stuff in async.c's pg_listening_channels() which should be cleaned up. Thanks for working on this, as the API is more explicit now about what is going on. Best regards, Jesper