Content-Type: multipart/mixed; boundary="------------kwFc66cDQJoGPT8sBjlMqK4n"
Message-ID: <f0c60283-1c3d-0f0e-166a-b667c154fe0a@postgresql.org>
Date: Thu, 4 Aug 2022 07:02:28 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: pg15b2: large objects lost on upgrade
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>, Robert Haas <robertmhaas@gmail.com>,
 Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
 Andrew Dunstan <andrew@dunslane.net>, Bruce Momjian <bruce@momjian.us>,
 Michael Paquier <michael@paquier.xyz>, Justin Pryzby <pryzby@telsasoft.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Shruthi Gowda <gowdashru@gmail.com>
References: <20220730054401.GB3644221@rfd.leadboat.com>
 <351616.1659192034@sss.pgh.pa.us>
 <635c8809-3525-7dae-a1a1-0d9069cd86bc@postgresql.org>
 <2657259.1659460333@sss.pgh.pa.us>
 <CA+TgmoastyZUAmJ6t953=yycQxu_S0x6A08QVARsbOVAWW=D2A@mail.gmail.com>
 <c07d096c-a67a-9fb9-2001-7a97b36aa5a7@postgresql.org>
 <2686054.1659469199@sss.pgh.pa.us>
 <98286e9b-8fe6-554e-c23f-d67a3df2c30d@postgresql.org>
 <2687956.1659469881@sss.pgh.pa.us>
 <CA+TgmoYqSrO-dSP6up31gv5F+1-zM-5exjKw2BU6w+FtzAzNhA@mail.gmail.com>
 <20220803202014.77m6z5m7v525p2b4@awork3.anarazel.de>
 <CA+TgmoYJaHNBghqALt-9FonK8FRB96m_MSNr9ev5EBto-2oMYw@mail.gmail.com>
 <3128525.1659559617@sss.pgh.pa.us>
 <CAH2-WzkmNN0kwPBO8t=waOCikWM4KLX9fWEYyt2oyWP08u3mSg@mail.gmail.com>
 <ddf43511-32fd-fc22-1b36-8e6c733a55b0@postgresql.org>
 <3260692.1659568781@sss.pgh.pa.us>
From: "Jonathan S. Katz" <jkatz@postgresql.org>
In-Reply-To: <3260692.1659568781@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/f0c60283-1c3d-0f0e-166a-b667c154fe0a%40postgresql.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------kwFc66cDQJoGPT8sBjlMqK4n
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 8/3/22 4:19 PM, Tom Lane wrote:
> "Jonathan S. Katz" <jkatz@postgresql.org> writes:
>> I did rule out wanting to do the "xid + $X" check after reviewing some
>> of the output. I think that both $X could end up varying, and it really
>> feels like a bandaid.
> 
> It is that.  I wouldn't feel comfortable with $X less than 100 or so,
> which is probably sloppy enough to draw Robert's ire.  Still, realizing
> that what we want right now is a band-aid for 15beta3, I don't think
> it's an unreasonable short-term option.

Attached is the "band-aid / sloppy" version of the patch. Given from the 
test examples I kept seeing deltas over 100 for relfrozenxid, I chose 
1000. The mxid delta was less, but I kept it at 1000 for consistency 
(and because I hope this test is short lived in this state), but can be 
talked into otherwise.

>> Andres suggested upthread using "txid_current()" -- for the comparison,
>> that's one thing I looked at. Would any of the XID info from
>> "pg_control_checkpoint()" also serve for this test?
> 
> I like the idea of txid_current(), but we have no comparable
> function for mxid do we?  While you could get both numbers from
> pg_control_checkpoint(), I doubt that's sufficiently up-to-date.

...unless we force a checkpoint in the test?

Jonathan
--------------kwFc66cDQJoGPT8sBjlMqK4n
Content-Type: text/plain; charset=UTF-8;
 name="pg_upgrade-test-gte-xid-v2.patch"
Content-Disposition: attachment; filename="pg_upgrade-test-gte-xid-v2.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfdXBncmFkZS90LzAwMl9wZ191cGdyYWRlLnBsIGIv
c3JjL2Jpbi9wZ191cGdyYWRlL3QvMDAyX3BnX3VwZ3JhZGUucGwKaW5kZXggNGNiYzc1NjQ0
Yy4uY2VkODg5NjAxZiAxMDA2NDQKLS0tIGEvc3JjL2Jpbi9wZ191cGdyYWRlL3QvMDAyX3Bn
X3VwZ3JhZGUucGwKKysrIGIvc3JjL2Jpbi9wZ191cGdyYWRlL3QvMDAyX3BnX3VwZ3JhZGUu
cGwKQEAgLTIyNiw2ICsyMjYsOCBAQCBPUkRFUiBCWSBjLm9pZDo6cmVnY2xhc3M6OnRleHQK
IEVPTQogJGhvcml6b25fcXVlcnkgPX4gcy9ccysvIC9nOyAjIHJ1biBpdCB0b2dldGhlciBv
biBvbmUgbGluZQogbXkgJGhvcml6b24xID0gJG9sZG5vZGUtPnNhZmVfcHNxbCgncmVncmVz
c2lvbicsICRob3Jpem9uX3F1ZXJ5KTsKK2Nob21wKCRob3Jpem9uMSk7CitteSBAaG9yaXpv
bjFfdmFsdWVzID0gc3BsaXQoL1x8LywgJGhvcml6b24xKTsKIAogIyBJbiBhIFZQQVRIIGJ1
aWxkLCB3ZSdsbCBiZSBzdGFydGVkIGluIHRoZSBzb3VyY2UgZGlyZWN0b3J5LCBidXQgd2Ug
d2FudAogIyB0byBydW4gcGdfdXBncmFkZSBpbiB0aGUgYnVpbGQgZGlyZWN0b3J5IHNvIHRo
YXQgYW55IGZpbGVzIGdlbmVyYXRlZCBmaW5pc2gKQEAgLTMxMyw2ICszMTUsOCBAQCAkbmV3
bm9kZS0+Y29tbWFuZF9vaygKIAogIyBBbmQgcmVjb3JkIHRoZSBob3Jpem9ucyBmcm9tIHRo
ZSB1cGdyYWRlZCBjbHVzdGVyIGFzIHdlbGwuCiBteSAkaG9yaXpvbjIgPSAkbmV3bm9kZS0+
c2FmZV9wc3FsKCdyZWdyZXNzaW9uJywgJGhvcml6b25fcXVlcnkpOworY2hvbXAoJGhvcml6
b24yKTsKK215IEBob3Jpem9uMl92YWx1ZXMgPSBzcGxpdCgvXHwvLCAkaG9yaXpvbjIpOwog
CiAjIENvbXBhcmUgdGhlIHR3byBkdW1wcywgdGhlcmUgc2hvdWxkIGJlIG5vIGRpZmZlcmVu
Y2VzLgogbXkgJGNvbXBhcmVfcmVzID0gY29tcGFyZSgiJHRlbXBkaXIvZHVtcDEuc3FsIiwg
IiR0ZW1wZGlyL2R1bXAyLnNxbCIpOwpAQCAtMzMxLDggKzMzNSwxMyBAQCBpZiAoJGNvbXBh
cmVfcmVzICE9IDApCiAJcHJpbnQgIj09PSBFT0YgPT09XG4iOwogfQogCi0jIENvbXBhcmUg
dGhlIGhvcml6b25zLCB0aGVyZSBzaG91bGQgYmUgbm8gZGlmZmVyZW5jZXMuCi1teSAkaG9y
aXpvbnNfb2sgPSAkaG9yaXpvbjEgZXEgJGhvcml6b24yOworIyBDb21wYXJlIHRoZSBob3Jp
em9ucy4gVGhlcmUgc2hvdWxkIGJlIG5vIGNoYW5nZSBpbiB0aGUgT0lELCBzbyB3ZSB3aWxs
IHRlc3QKKyMgZm9yIGVxdWFsaXR5LiBIb3dldmVyLCBiZWNhdXNlIGF1dG92YWN1dW0gbWF5
IGhhdmUgcnVuIGJldHdlZW4gdGhlIHR3bworIyBob3JpemlvbnMsIHdlIHdpbGwgY2hlY2sg
aWYgdGhlIHVwZGF0ZWQgaG9yaXpvbiBYSURzIGFyZSBncmVhdGVyIHRoYW4gb3IKKyMgZXF1
YWwgdG8gdGhlIG9yaWdpbmFscy4KK215ICRob3Jpem9uc19vayA9ICRob3Jpem9uMl92YWx1
ZXNbMF0gZXEgJGhvcml6b24xX3ZhbHVlc1swXSAmJgorCWludCgkaG9yaXpvbjJfdmFsdWVz
WzFdKSA8PSBpbnQoJGhvcml6b24xX3ZhbHVlc1sxXSkgKyAxMDAwICYmCisJaW50KCRob3Jp
em9uMl92YWx1ZXNbMl0pIDw9IGludCgkaG9yaXpvbjFfdmFsdWVzWzJdKSArIDEwMDA7CiBv
aygkaG9yaXpvbnNfb2ssICdvbGQgYW5kIG5ldyBob3Jpem9ucyBtYXRjaCBhZnRlciBwZ191
cGdyYWRlJyk7CiAKICMgUHJvdmlkZSBtb3JlIGNvbnRleHQgaWYgdGhlIGhvcml6b25zIGRv
IG5vdCBtYXRjaC4K

--------------kwFc66cDQJoGPT8sBjlMqK4n--