Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r27Hq-00F7K2-Fr for pgsql-hackers@arkaria.postgresql.org; Sun, 12 Nov 2023 10:01:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r27Ho-00AFTZ-DC for pgsql-hackers@arkaria.postgresql.org; Sun, 12 Nov 2023 10:01:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r27Ho-00AFRw-2Z for pgsql-hackers@lists.postgresql.org; Sun, 12 Nov 2023 10:01:48 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1r27Hi-005C0n-7n for pgsql-hackers@lists.postgresql.org; Sun, 12 Nov 2023 10:01:43 +0000 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-5098e423ba2so4860721e87.2 for ; Sun, 12 Nov 2023 02:01:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1699783300; x=1700388100; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CD2iDN6QWY/acFsxMPAx4+iMv6yZok3SGymOaGa+7C4=; b=Uyy8Znf0HJVMmplMUStfcGzFx5Ws9rKMCwVWh0AJO0sCWV6eafdri+El9VDCFl5Rg+ XXwJ/CsGH2YlehhRrGNbsvN4XxifgozoMmqZFP6Jr1cmtkrVyDpPGplYX7p/St3FvLJX TnTdPDW17xwsW5PdlCDoMdJ9pLJlucG+vJfkZQR73NlBuxAunvuNAHrMoh4FeuDAuSLn 7Ul/Xhzk7r0qMav87UhlYQJ9em1ebGk+l9PvXZzyZ88I/NO5mlQzqj+/QdR1j/aEflQF kPlQzrE64NomOgQC45Jk83KOkyFDDbuklFCvFhEfoDhf8461eddfJmSHP5FoBqG7zuHw 5GAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699783300; x=1700388100; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CD2iDN6QWY/acFsxMPAx4+iMv6yZok3SGymOaGa+7C4=; b=bsp0q+yu0CGgg+nRivS6aoU3tO/JYLemkHej22hTopEylgsyJAlD6bVu+CEmr4VouI Z8umxRWws298BfGebHPIsunEZU7AE/bTE0q5EaIX4mrAEP3WrUxCdacQpqEYmjCdWZli vlcSEChOQWYlnDjjPHsP/N6miIJLZeWTGhy4VgW7WOzshUokVN32KdnOPV346SBKviOV blL/tSOK54gPyXWpMpJZOs2J/QkoJF33VGhijHWWEJlF+LeoyzLR2qtVrT2FScJq6utW P//+sOeKdyloefWPDjI8myIPyS2XQehckc+/oYELP1E29ZDJrMWBzjlc25TVlm8HNFpX ZScw== X-Gm-Message-State: AOJu0YynjFsbRYZge3/+ncyuAiPl7BtNx/llyzXLI8oiyZ0dXbflN/8P kHwcyEZSBoYLOgd9GFkAqMSvBA== X-Google-Smtp-Source: AGHT+IEsjNexG8gNJ1ICzQ23Pzy4dP72qSzR9yXjqcNXYOEIJBgopnUnSoGqct/DTawdSQC4VQyeCw== X-Received: by 2002:a05:651c:1191:b0:2c5:d3c:8f4d with SMTP id w17-20020a05651c119100b002c50d3c8f4dmr2239535ljo.13.1699783299940; Sun, 12 Nov 2023 02:01:39 -0800 (PST) Received: from [10.137.0.17] (cst-prg-87-252.cust.vodafone.cz. [46.135.87.252]) by smtp.gmail.com with ESMTPSA id w21-20020a05600c475500b003feae747ff2sm10498666wmo.35.2023.11.12.02.01.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Nov 2023 02:01:39 -0800 (PST) Message-ID: Date: Sun, 12 Nov 2023 11:01:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: Parallel CREATE INDEX for BRIN indexes To: Matthias van de Meent Cc: PostgreSQL Hackers References: <2d7c64de-716e-346e-b01e-03db0c2bc5ac@enterprisedb.com> <2e86059f-4004-eec1-2bc1-9e7fd119c9e2@enterprisedb.com> Content-Language: en-US From: Tomas Vondra In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 11/12/23 10:38, Matthias van de Meent wrote: > On Wed, 8 Nov 2023 at 12:03, Tomas Vondra wrote: >> >> Hi, >> >> here's an updated patch, addressing the review comments, and reworking >> how the work is divided between the workers & leader etc. > > Thanks! > >> In general I'm quite happy with the current state, and I believe it's >> fairly close to be committable. > > Are you planning on committing the patches separately, or squashed? I > won't have much time this week for reviewing the patch, and it seems > like these patches are incremental, so some guidance on what you want > to be reviewed would be appreciated. > Definitely squashed. I only kept them separate to make it more obvious what the changes are. If you need more time for a review, I can certainly wait. No rush. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company