Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tmbDH-007xho-KQ for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Feb 2025 16:21:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tmbDG-004kO2-Ur for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Feb 2025 16:21:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tmbDG-004kNr-I0 for pgsql-hackers@lists.postgresql.org; Mon, 24 Feb 2025 16:21:46 +0000 Received: from mail1.dalibo.net ([51.159.93.128] helo=mail.dalibo.com) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tmbDD-000Z1A-2T for pgsql-hackers@postgresql.org; Mon, 24 Feb 2025 16:21:46 +0000 Received: from [192.168.1.23] (unknown [90.58.191.166]) by mail.dalibo.com (Postfix) with ESMTPSA id 598FA2807C; Mon, 24 Feb 2025 17:21:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dalibo.com; s=a; t=1740414102; bh=uBp2aI1h5RTYm2nQRNxIKWgM8PHHMLyMwsWA4ykRuSM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hC6GBczgNNRaa2im6ZAjkW61TGkUL2SPal4EVQT0E6p8GI2bnMAXG5SIHsxgVn7nT 7MaHeG/mYViiJu1nCFzefKLOrWJBkgF17PO0MGYjB+scS4VEAP/ek9vAknO3adnwuO 19GusOyW4Ey5cIUJSBYzQwpowWuueqF1IeSsSSvg= Content-Type: multipart/mixed; boundary="------------Fu741Nd64GZTribohn9OLlli" Message-ID: Date: Mon, 24 Feb 2025 17:21:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Fix logging for invalid recovery timeline To: Michael Paquier , David Steele Cc: "Andrey M. Borodin" , Pg Hackers References: <4ed10bc8-5513-4d8e-8643-8abcaa08336d@dalibo.com> <2765f538-b06f-4e57-bcb2-9ca1dc6f487d@pgbackrest.org> <6273ef0b-033b-4ac7-ab05-71a04e7ac626@pgbackrest.org> <173a9a4a-bad3-4a42-91e1-637f70e9512f@dalibo.com> <5336e68a-30d0-473f-a0a0-9e61cd9a5a63@pgbackrest.org> Content-Language: fr From: =?UTF-8?Q?Benoit_Lobr=C3=A9au?= Autocrypt: addr=benoit.lobreau@dalibo.com; keydata= xsBNBF3FR7IBCADDvtR0p09SI9OvnbWw+VEvO5IXefBWFWefxrPd0H3Sf3gsBLiKbRdkSjvz 2y+ksRgBUkhK1Kiqe/QuddgvuT9OUFBCrOtZxkBgJYRbxBNTOnIehhEoK9sdqjwvwNyxJUEX er1UgErP+MJTvwpW1J8Uq9oV+NbqgNQ7ca5G2D3x7DI2Tbbw0iu+lmCIdXQpTk7hacErGscC p/eaJQFd6EPAZPS7BQEgjuDDjGCy4RzTSiobtqn0ocaEj+w7365FVKKZD2LjEm1mfBK/4nml H/vlssXkKKpUGetaib6AVpZK3a0xBTMi04ft/V8iGGJuVhE45WjjKSckmeLafTZCGxN9ABEB AAHNK0Jlbm9pdCBMb2Jyw6lhdSA8YmVub2l0LmxvYnJlYXVAZGFsaWJvLmNvbT7CwJQEEwEI AD4CGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AWIQRkbHJAht3VPY+ptaDDJY+vq0O76wUC Za56QgUJC6uZkAAKCRDDJY+vq0O760ECCACDPj6p9VXaX4GF9p+3zhoDwxsUWh0xODwsK//h SBGsRmPaElApbOR5rs2WDFaPE95XG3Vdo2rno7i4mt0fASls7vq4P0BPJiPM4fKEr+kfXAxP 2clqmkBMn2o+EEeUGDmnn3RAVzDDoyML6N/unpyOTHWfscxvvj6AKreUtxzQm0LVQRL+hIaG SAlcwpVWQBPhA6Roi1/7Uz9qm8nWjFOuV6vO5yVe0sfRrrO9AFkjBGFT/B06sSs33Os6Hjs5 2ckLn5Gxlty8XgTpbaG0bJiV+GDTcXh5UV8XVKaMomOLJxWw8US6PSSqQxodWuJqsvlxXV93 ae6cMIosHsriaUo5zsBNBF3FR7IBCADEWwsQar1qtLKdoAoqKThz+kQXu3UADQ0c8JCgsp+8 a6hFDg+uIw0j852lkJOPHll414Qw+kLC1bUo7H6+mPHzko/aR3TFz6vvOrm0afwFP7sm9Vbe UbpeohnrXBBwb1PjNhDphaXeMVovJqSgRifhc/sAR6fXi+2OCrH+8CUYa0aHhwoecStgw/tm EDPZ8lCsg5IdyO5Er4ZMOl/EbaRuTOpl7U/GzJBQSYf7t4KHotIpEeuJVv4X/+nTW3ALG+dG pRA5GplNnlQNfsEymnT4W7RbfafDp7Q7nK6w7d55ZU8UyiS6N/1wh/DL1hntC65lQbHlmwNx RG132ecNOcqFABEBAAHCwHwEGAEIACYCGwwWIQRkbHJAht3VPY+ptaDDJY+vq0O76wUCZa56 dQUJC6uZwwAKCRDDJY+vq0O76y9jB/0fVyz7D56D2A6MUGASNkh6IiuHCF/UgEfU0m5fC6pd 38+fmyUMkGR3QwrtZP3SCLaBKT4LHxhVu7tEUWI+6WK7/s0Jsx5L8aIfDKY4zjqQ9InP+LkA azkKW4JpIb9Ny0FzRjUyf9gReU5nMy9sUNS4DhoHG6c/bQYqkj9uA5AokiDDCRg2dobfpaNP C6qQQIXD+wi0aZ4jR5r4rXMxmwFutandoaxDpPBj4EXlyRHhzyKfgb2c6TXdCVQ5YJUFUi9k gl7CXplN8vBpMuzN5y6NPd3Xekcp16D5XCQNBQ2drIsnFR4IbDPI1Mqd6OJYH0vum6g8FmoN s7ygc4oi12nU In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------Fu741Nd64GZTribohn9OLlli Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/24/25 2:05 AM, Michael Paquier wrote: > I think that you have the right idea here, avoiding the duplication > of the errdetail() which feels itchy when looking at the patch. Done this way in the attached patch. > This should have a note for translators that this field refers to a file > name. Is there a specific way todo this? -- Benoit Lobréau Consultant http://dalibo.com --------------Fu741Nd64GZTribohn9OLlli Content-Type: text/x-patch; charset=UTF-8; name="V2_0001-Adjust-logging-for-invalid-recovery-timeline.patch" Content-Disposition: attachment; filename*0="V2_0001-Adjust-logging-for-invalid-recovery-timeline.patch" Content-Transfer-Encoding: base64 RnJvbSAzNWRkOGRiMjJjOTk3ZTc4YmE5MmY2M2ZmY2EzMDIyYjQzNWQ3MzA0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBiZW5vaXQgPGJlbm9pdC5sb2JyZWF1QGRhbGliby5j b20+CkRhdGU6IEZyaSwgMjEgRmViIDIwMjUgMTQ6MDk6NTYgKzAxMDAKU3ViamVjdDogW1BB VENIXSBBZGp1c3QgbG9nZ2luZyBmb3IgaW52YWxpZCByZWNvdmVyeSB0aW1lbGluZQoKVGhl IG9yaWdpbmFsIG1lc3NhZ2UgZG9lc24ndCBtZW50aW9uIHdoZXJlIHRoZSBjaGVja3BvaW50 IHdhcyByZWFkIGZyb20uCkl0IHJlZmVycyB0byB0aGUgIkxhdGVzdCBjaGVja3BvaW50Iiwg dGhlIHRlcm1pbm9sb2d5IGlzIHVzZWQgZm9yIHNvbWUKcmVjb3JkcyBmcm9tIHRoZSBjb250 cm9sIGZpbGUgKHNwZWNpZmljYWxseSwgdGhlIHBnX2NvbnRyb2xkYXRhIG91dHB1dCkuClRo ZSBiYWNrdXAgbGFiZWwgdXNlcyAiQ2hlY2twb2ludCBsb2NhdGlvbiIuCi0tLQogc3JjL2Jh Y2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZ3JlY292ZXJ5LmMgfCAzICsrLQogMSBmaWxlIGNo YW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3Ny Yy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2dyZWNvdmVyeS5jIGIvc3JjL2JhY2tlbmQv YWNjZXNzL3RyYW5zYW0veGxvZ3JlY292ZXJ5LmMKaW5kZXggOTE1Y2IzMzAyOTUuLmM1MTYw YmY1MjU4IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9ncmVj b3ZlcnkuYworKysgYi9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9ncmVjb3Zlcnku YwpAQCAtODQ5LDcgKzg0OSw4IEBAIEluaXRXYWxSZWNvdmVyeShDb250cm9sRmlsZURhdGEg KkNvbnRyb2xGaWxlLCBib29sICp3YXNTaHV0ZG93bl9wdHIsCiAJCWVyZXBvcnQoRkFUQUws CiAJCQkJKGVycm1zZygicmVxdWVzdGVkIHRpbWVsaW5lICV1IGlzIG5vdCBhIGNoaWxkIG9m IHRoaXMgc2VydmVyJ3MgaGlzdG9yeSIsCiAJCQkJCQlyZWNvdmVyeVRhcmdldFRMSSksCi0J CQkJIGVycmRldGFpbCgiTGF0ZXN0IGNoZWNrcG9pbnQgaXMgYXQgJVgvJVggb24gdGltZWxp bmUgJXUsIGJ1dCBpbiB0aGUgaGlzdG9yeSBvZiB0aGUgcmVxdWVzdGVkIHRpbWVsaW5lLCB0 aGUgc2VydmVyIGZvcmtlZCBvZmYgZnJvbSB0aGF0IHRpbWVsaW5lIGF0ICVYLyVYLiIsCisJ CQkJIGVycmRldGFpbCgiTGF0ZXN0IGNoZWNrcG9pbnQgaW4gJXMgaXMgYXQgJVgvJVggb24g dGltZWxpbmUgJXUsIGJ1dCBpbiB0aGUgaGlzdG9yeSBvZiB0aGUgcmVxdWVzdGVkIHRpbWVs aW5lLCB0aGUgc2VydmVyIGZvcmtlZCBvZmYgZnJvbSB0aGF0IHRpbWVsaW5lIGF0ICVYLyVY LiIsCisJCQkJCQkgICBoYXZlQmFja3VwTGFiZWwgPyAiYmFja3VwX2xhYmVsIiA6ICJwZ19j b250cm9sIiwKIAkJCQkJCSAgIExTTl9GT1JNQVRfQVJHUyhDaGVja1BvaW50TG9jKSwKIAkJ CQkJCSAgIENoZWNrUG9pbnRUTEksCiAJCQkJCQkgICBMU05fRk9STUFUX0FSR1Moc3dpdGNo cG9pbnQpKSkpOwotLSAKMi40OC4xCgo= --------------Fu741Nd64GZTribohn9OLlli--