public inbox for [email protected]  

help / color / mirror / Atom feed

From: Drouvot, Bertrand <[email protected]>
To: Robert Haas <[email protected]>
To: Andres Freund <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: pgsql: TAP test for logical decoding on standby
Date: Wed, 24 May 2023 13:58:54 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmobHGpU2ZkChgKifGDLaf_+mFA7njEpeTjfyNf_msCZYew@mail.gmail.com>
References: <[email protected]>
	<CA+TgmobHGpU2ZkChgKifGDLaf_+mFA7njEpeTjfyNf_msCZYew@mail.gmail.com>

Hi,

On 5/23/23 5:15 PM, Robert Haas wrote:
> On Sat, Apr 8, 2023 at 5:26 AM Andres Freund <[email protected]> wrote:
>> TAP test for logical decoding on standby
> 
> Small nitpicks:
> 
> 1. The test names generated by check_slots_conflicting_status() start
> with a capital letter, while most other test names start with a
> lower-case letter.
> 

Yeah, not sure that would deserve a fix for its own but if we address 2.
then let's do 1. too.

> 2. The function is called 7 times, 6 with a true argument and 1 with a
> false argument, but the test name only depends on whether the argument
> is true or false, so we get the same test name 6 times. Maybe there's
> not a reasonable way to do better, I'm not sure, but it's not ideal.
> 

I agree that's not ideal (but one could still figure out which one is
failing if any by looking at the perl script).

If we want to "improve" this, what about passing a second argument that
would provide more context in the test name?

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgsql: TAP test for logical decoding on standby
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox