Message-ID: <f0e6301d-dcad-85cc-1e9d-d70ad25fd0ea@gmail.com>
Date: Fri, 15 Mar 2024 10:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: Add the ability to limit the amount of memory that can be
 allocated to backends.
Content-Language: en-US
To: "Anton A. Melnikov" <a.melnikov@postgrespro.ru>,
 Aleksander Alekseev <aleksander@timescale.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>,
 Andres Freund <andres@anarazel.de>,
 Andrei Lepikhov <a.lepikhov@postgrespro.ru>,
 Stephen Frost <sfrost@snowman.net>, reid.thompson@crunchydata.com,
 Arne Roland <A.Roland@index.de>, vignesh C <vignesh21@gmail.com>,
 Justin Pryzby <pryzby@telsasoft.com>, Ibrar Ahmed <ibrar.ahmad@gmail.com>,
 "stephen.frost" <stephen.frost@crunchydata.com>
References: <7912c911af51d5cf28c611190bf3d463b9209343.camel@crunchydata.com>
 <4edafedc0f8acb12a2979088ac1317bd7dd42145.camel@crunchydata.com>
 <f62b4107-227d-49e7-a9be-104d1ceb03d9@postgrespro.ru>
 <268e0ac7-8a81-4d65-8b40-b62c4b3f1bf9@postgrespro.ru>
 <ZTArWsctGn5fEVPR@tamriel.snowman.net>
 <48548d40-634b-4943-a737-3c9d95eacf06@postgrespro.ru>
 <ZTGoUt+pH8uPucfm@tamriel.snowman.net>
 <c6520d47-e584-4287-833c-82779cc166e0@postgrespro.ru>
 <ZTJ1BfHC99LSzoHw@tamriel.snowman.net>
 <8fcb4406-49f5-4069-b8e9-197a38004ddd@postgrespro.ru>
 <20231024024435.yaqrajcchcliwhjl@awork3.anarazel.de>
 <fbfad1e7-65ba-4202-95df-da9b8177d821@postgrespro.ru>
 <98646b96-6dcf-8d8a-3daf-837f25f8b1e3@enterprisedb.com>
 <a74b5a91-d7c1-4138-86df-371c5e2b2be3@postgrespro.ru>
 <1c5f1856-817d-45e5-8e1a-acd95c6dd335@enterprisedb.com>
 <CAJ7c6TOkVonAEoAc_touS_doFWvJzzo=mY7CY8Hbyp1ekkRrgQ@mail.gmail.com>
 <a8b92342-9e58-4d8d-9c22-f6054087db24@postgrespro.ru>
 <e37c0a61-891b-4929-b9ba-6dd8cad140fd@postgrespro.ru>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <e37c0a61-891b-4929-b9ba-6dd8cad140fd@postgrespro.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/f0e6301d-dcad-85cc-1e9d-d70ad25fd0ea%40gmail.com>
Precedence: bulk

Hello Anton,

14.03.2024 23:36, Anton A. Melnikov wrote:
> On 13.03.2024 10:41, Anton A. Melnikov wrote:
>
>> Here is a version updated for the current master.
>>
>
> During patch updating i mistakenly added double counting of deallocatated blocks.
> That's why the tests in the patch tester failed.
> Fixed it and squashed fix 0002 with 0001.
> Here is fixed version.

Please try the following with the patches applied:
echo "shared_buffers = '1MB'
max_total_backend_memory = '10MB'" > /tmp/extra.config

CPPFLAGS="-Og" ./configure --enable-tap-tests --enable-debug --enable-cassert ...
TEMP_CONFIG=/tmp/extra.config make check

It fails for me as follows:
...
# postmaster did not respond within 60 seconds, examine ".../src/test/regress/log/postmaster.log" for the reason
...
src/test/regress/log/postmaster.log contains:
...
TRAP: failed Assert("ret != NULL"), File: "mcxt.c", Line: 1327, PID: 4109270
TRAP: failed Assert("ret != NULL"), File: "mcxt.c", Line: 1327, PID: 4109271
postgres: autovacuum launcher (ExceptionalCondition+0x69)[0x55ce441fcc6e]
postgres: autovacuum launcher (palloc0+0x0)[0x55ce4422eb67]
postgres: logical replication launcher (ExceptionalCondition+0x69)[0x55ce441fcc6e]
postgres: autovacuum launcher (InitDeadLockChecking+0xa6)[0x55ce4408a6f0]
postgres: logical replication launcher (palloc0+0x0)[0x55ce4422eb67]
postgres: logical replication launcher (InitDeadLockChecking+0x45)[0x55ce4408a68f]
postgres: autovacuum launcher (InitProcess+0x600)[0x55ce4409c6f2]
postgres: logical replication launcher (InitProcess+0x600)[0x55ce4409c6f2]
postgres: autovacuum launcher (+0x44b4e2)[0x55ce43ff24e2]
...
grep TRAP src/test/regress/log/postmaster.log | wc -l
445

Best regards,
Alexander