Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5PpW-0005Cd-7s for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Jul 2021 09:44:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m5PpV-0008Ts-6l for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Jul 2021 09:44:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5PpU-0008Rv-RQ for pgsql-hackers@lists.postgresql.org; Mon, 19 Jul 2021 09:44:52 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m5PpT-0006QU-8y for pgsql-hackers@lists.postgresql.org; Mon, 19 Jul 2021 09:44:52 +0000 Received: from [10.0.1.15] (unknown [188.123.231.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id AAB6721CA40B for ; Mon, 19 Jul 2021 12:44:50 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1626687890; bh=3POt/JssPkDHJHlUnHd5qg3zX1oMXk7iZblClElYKW4=; h=To:From:Subject:Date; b=BoOy4lQv+WyJ7/ANhpg0H8NO68lnTLeyIG67MpUuwrdjj5IH5w1LwO92mmttE+7Vb Jej6Fmd5MT1HbXZfpv9/ne3cggYKZVgy4u3pb9URhHMvwuZdEQAp1X3X7BuWJfY9kT erthRVwQ9PApZQWdKSiKbJL2EjCxoUmThy/wER7s= To: "pgsql-hackers@lists.postgresql.org" From: Pavel Luzanov Subject: postgresql.conf.sample missing units Message-ID: Date: Mon, 19 Jul 2021 12:44:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------B5572CB0FAC0EFB9F2EA4B5E" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------B5572CB0FAC0EFB9F2EA4B5E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hello, I found that the start section of the postgresql.conf file is missing a description of two units: bytes (appeared in version 11) and microseconds (in version 12). The attached patch makes these changes to the postgresql.conf.sample file. -- Pavel Luzanov Postgres Professional: https://postgrespro.com The Russian Postgres Company --------------B5572CB0FAC0EFB9F2EA4B5E Content-Type: text/x-patch; charset=UTF-8; name="add-units-in-sample.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="add-units-in-sample.patch" diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample index ccaaf63850..b242a7fc8b 100644 --- a/src/backend/utils/misc/postgresql.conf.sample +++ b/src/backend/utils/misc/postgresql.conf.sample @@ -24,7 +24,8 @@ # "postgres -c log_connections=on". Some parameters can be changed at run time # with the "SET" SQL command. # -# Memory units: kB = kilobytes Time units: ms = milliseconds +# Memory units: B = bytes Time units: us = microseconds +# kB = kilobytes ms = milliseconds # MB = megabytes s = seconds # GB = gigabytes min = minutes # TB = terabytes h = hours --------------B5572CB0FAC0EFB9F2EA4B5E--