Feedback-ID: ie0a040ee:Fastmail
Message-ID: <f122c665-ec76-4f3f-9c5d-a08136ac9487@eisentraut.org>
Date: Fri, 3 May 2024 15:57:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Tarball builds in the new world order
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Greg Sabino Mullane <htamfids@gmail.com>,
 pgsql-hackers@lists.postgresql.org, Magnus Hagander <magnus@hagander.net>
References: <3552543.1713909947@sss.pgh.pa.us>
 <CAKAnmmLS20mob0wWibo9ZNoMzxnP=LYN85dd41iy+KeuPN73+A@mail.gmail.com>
 <3709288.1713972073@sss.pgh.pa.us> <15181.1714159448@sss.pgh.pa.us>
 <1e596327-9698-4111-a528-a6a2749351fe@eisentraut.org>
 <1245434.1714407250@sss.pgh.pa.us>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <1245434.1714407250@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/f122c665-ec76-4f3f-9c5d-a08136ac9487%40eisentraut.org>
Precedence: bulk

On 29.04.24 18:14, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> On 26.04.24 21:24, Tom Lane wrote:
>>> Concretely, I'm proposing the attached.  Peter didn't like
>>> PG_COMMIT_HASH, so I have PG_COMMIT_REFSPEC below, but I'm not
>>> wedded to that if a better name is proposed.
> 
>> This seems ok to me, but note that we do have an equivalent
>> implementation in meson.  If we don't want to update that in a similar
>> way, maybe we should disable it.
> 
> OK.  After poking at that for awhile, it seemed like "default to
> HEAD" fits into meson a lot better than "throw an error if the
> variable isn't set", so I switched to doing it like that.
> One reason is that AFAICT you can only set the variable during
> "meson setup" not during "ninja".  This won't matter to the
> tarball build script, which does a one-off configuration run
> anyway.  But for manual use, a movable target like HEAD might be
> more convenient given that behavior.

This patch looks good to me.