Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wwcNA-0025cV-2l for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Aug 2026 09:14:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wwcN9-002aHY-1m for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Aug 2026 09:14:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wwcN9-002aHP-0h for pgsql-hackers@lists.postgresql.org; Wed, 19 Aug 2026 09:14:11 +0000 Received: from email.dnscdc.tech ([194.226.250.15]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wwcN6-000000005qQ-1tsM for pgsql-hackers@lists.postgresql.org; Wed, 19 Aug 2026 09:14:10 +0000 Received: with id 00700280D7B; Wed, 19 Aug 2026 16:14:06 +0700 (+07) Received: with id 98E4528002C; Wed, 19 Aug 2026 16:14:00 +0700 (+07) From: Sivirilova Marija To: Daniel Gustafsson CC: "pgsql-hackers@lists.postgresql.org" Subject: RE: [PATCH] Fix heap-buffer-overflow in PGTYPEStimestamp_defmt_scan() Thread-Topic: [PATCH] Fix heap-buffer-overflow in PGTYPEStimestamp_defmt_scan() Thread-Index: Ad0vpeJg8BKG0/PiSQC9p6r6N35urf//o6wA//97R7A= Date: Wed, 19 Aug 2026 09:13:58 +0000 Message-ID: References: <5BDD13C9-D6C8-475D-9946-61A165C2C822@yesql.se> In-Reply-To: <5BDD13C9-D6C8-475D-9946-61A165C2C822@yesql.se> Accept-Language: ru-RU, en-US Content-Language: ru-RU X-MS-Has-Attach: yes X-MS-TNEF-Correlator: Content-Type: multipart/mixed; boundary="_002_f159cf94e6694f11af783616234683dcftdataru_" MIME-Version: 1.0 X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Lua-Profiles: 205402 [Aug 19 2026] X-KLMS-AntiSpam-Version: 6.1.1.27 X-KLMS-AntiSpam-Envelope-From: m.sivirilova@ftdata.ru X-KLMS-AntiSpam-Rate: 0 X-KLMS-AntiSpam-Status: not_detected X-KLMS-AntiSpam-Method: none X-KLMS-AntiSpam-Auth: dkim=none X-MS-Exchange-Organization-SCL: -1 X-KLMS-AntiSpam-Interceptor-Info: scan successful X-KLMS-AntiPhishing: Clean, bases: 2026/08/19 08:47:00 X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, bases: 2026/08/19 08:45:00 #28532348 X-KLMS-AntiVirus-Status: Clean, skipped List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --_002_f159cf94e6694f11af783616234683dcftdataru_ Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: quoted-printable I'm sending you an updated patch. A test has been added to src/interfaces/e= cpg/test/pgtypeslib/dt_test2.pgc. It works without compiling AddressSanitiz= er. Test result before patch: ... interval_copy[5]: @ 1 year 59 mins Error parsing interval 6 free(): invalid next size (fast) Aborted (core dumped) After patch: ... interval_copy[5]: @ 1 year 59 mins Error parsing interval 6 Success parsing large string -- Maria Sivirilova -----Original Message----- From: Daniel Gustafsson =20 Sent: Wednesday, August 19, 2026 3:12 PM To: =F3=C9=D7=C9=D2=C9=CC=CF=D7=C1 =ED=C1=D2=C9=D1 =EB=CF=CE=D3=D4=C1=CE=D4= =C9=CE=CF=D7=CE=C1 Cc: pgsql-hackers@lists.postgresql.org Subject: Re: [PATCH] Fix heap-buffer-overflow in PGTYPEStimestamp_defmt_sca= n() > On 19 Aug 2026, at 08:55, Sivirilova Marija wrot= e: >=20 > Hello, hackers! > We used the Clang Static Analyzer and found a heap-buffer-overflow in th= e PGTYPEStimestamp_defmt_scan() function inside src/interfaces/ecpg/pgtypes= lib/dt_common.c. When processing template tokens like '%D', '%r', '%R', or = '%T', the code allocates a temporary buffer based on the length of the rema= ining input string (pstr). However, it later concatenates the remaining for= mat string (pfmt) into this buffer using strcat(). If an application attemp= ts to parse a short or truncated time string using a longer, complex format= pattern, the format string suffix will exceed the allocated memory, causin= g a heap-buffer-overflow. > The issue can be reproduced with a minimal test case (compiling this wit= h AddressSanitizer): Can you please add testcases to the patch, to make sure we cover these edge= cases in the regression tests. -- Daniel Gustafsson --_002_f159cf94e6694f11af783616234683dcftdataru_ Content-Type: application/octet-stream; name="Fix-heap-buffer-overflow.patch" Content-Description: Fix-heap-buffer-overflow.patch Content-Disposition: attachment; filename="Fix-heap-buffer-overflow.patch"; size=3233; creation-date="Wed, 19 Aug 2026 06:27:50 GMT"; modification-date="Wed, 19 Aug 2026 09:12:44 GMT" Content-Transfer-Encoding: base64 RnJvbSBlZWI4ZTY4Yjc5ZTM4ZDkyNWNlN2NhYzZhYjJhMzU2ZGY5Nzk5YmI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTaXZpcmlsb3ZhIE1hcmlhIDxtLnNpdmlyaWxvdmFAZnRkYXRh LnJ1PgpEYXRlOiBXZWQsIDE5IEF1ZyAyMDI2IDE2OjA1OjMyICswNzAwClN1YmplY3Q6IFtQQVRD SF0gRml4IGhlYXAtYnVmZmVyLW92ZXJmbG93IGluIFBHVFlQRVN0aW1lc3RhbXBfZGVmbXRfc2Nh bigpCgpXaGVuIHBhcnNpbmcgZm9ybWF0IHRva2VucyAnJUQnLCAnJXInLCAnJVInLCBvciAnJVQn LCB0aGUgZnVuY3Rpb24KYWxsb2NhdGVkIG1lbW9yeSBmb3IgdGhlIHRlbXBvcmFyeSBidWZmZXIg YmFzZWQgb24gdGhlIGxlbmd0aCBvZiB0aGUKcmVtYWluaW5nIGlucHV0IHN0cmluZyAocHN0ciku IEhvd2V2ZXIsIGl0IHN1YnNlcXVlbnRseSBhcHBlbmRlZCB0aGUKcmVtYWluaW5nIGZvcm1hdCBz dHJpbmcgKHBmbXQpIHRvIHRoYXQgYnVmZmVyIHZpYSBzdHJjYXQoKS4KCklmIHRoZSB0YWlsIG9m IHRoZSBmb3JtYXQgc3RyaW5nIGhhcHBlbmVkIHRvIGJlIGxvbmdlciB0aGFuIHRoZSByZW1haW5p bmcKaW5wdXQgc3RyaW5nLCBhIGhlYXAtYnVmZmVyLW92ZXJmbG93IG9jY3VycmVkLgoKRml4IHRo aXMgYnkgY2FsY3VsYXRpbmcgdGhlIHJlcXVpcmVkIGJ1ZmZlciBzaXplIHVzaW5nIHRoZSBsZW5n dGggb2YKdGhlIGZvcm1hdCBzdHJpbmcgKHBmbXQpIGluc3RlYWQgb2YgdGhlIGlucHV0IHN0cmlu ZyAocHN0cikuCgpBdXRob3I6IE1hcmlhIFNpdmlyaWxvdmEgPG0uc2l2aXJpbG92YUBmdGRhdGEu cnU+CkNvLWF1dGhvcmVkLWJ5OiBLYW5hdGJlayBLYW55YmVrb3YgPGsua2FueWJla292QGZ0ZGF0 YS5ydT4KLS0tCiBzcmMvaW50ZXJmYWNlcy9lY3BnL3BndHlwZXNsaWIvZHRfY29tbW9uLmMgICAg ICAgfCA4ICsrKystLS0tCiBzcmMvaW50ZXJmYWNlcy9lY3BnL3Rlc3QvcGd0eXBlc2xpYi9kdF90 ZXN0Mi5wZ2MgfCA5ICsrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCsp LCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9pbnRlcmZhY2VzL2VjcGcvcGd0eXBl c2xpYi9kdF9jb21tb24uYyBiL3NyYy9pbnRlcmZhY2VzL2VjcGcvcGd0eXBlc2xpYi9kdF9jb21t b24uYwppbmRleCBmMDg4OWRkZGFmOS4uNmQ1OGRlZTc4OTAgMTAwNjQ0Ci0tLSBhL3NyYy9pbnRl cmZhY2VzL2VjcGcvcGd0eXBlc2xpYi9kdF9jb21tb24uYworKysgYi9zcmMvaW50ZXJmYWNlcy9l Y3BnL3BndHlwZXNsaWIvZHRfY29tbW9uLmMKQEAgLTI2NTgsNyArMjY1OCw3IEBAIFBHVFlQRVN0 aW1lc3RhbXBfZGVmbXRfc2NhbihjaGFyICoqc3RyLCBjaGFyICpmbXQsIHRpbWVzdGFtcCAqIGQs CiAJCQkJICogZmluZCB0aGUgZW5kIG9mIHRoZSBzdWJzdGl0dXRpb24KIAkJCQkgKi8KIAkJCQlw Zm10Kys7Ci0JCQkJdG1wID0gcGd0eXBlc19hbGxvYyhzdHJsZW4oIiVtLyVkLyV5IikgKyBzdHJs ZW4ocHN0cikgKyAxKTsKKwkJCQl0bXAgPSBwZ3R5cGVzX2FsbG9jKHN0cmxlbigiJW0vJWQvJXki KSArIHN0cmxlbihwZm10KSArIDEpOwogCQkJCWlmICghdG1wKQogCQkJCQlyZXR1cm4gMTsKIAkJ CQlzdHJjcHkodG1wLCAiJW0vJWQvJXkiKTsKQEAgLTI3ODUsNyArMjc4NSw3IEBAIFBHVFlQRVN0 aW1lc3RhbXBfZGVmbXRfc2NhbihjaGFyICoqc3RyLCBjaGFyICpmbXQsIHRpbWVzdGFtcCAqIGQs CiAJCQkJYnJlYWs7CiAJCQljYXNlICdyJzoKIAkJCQlwZm10Kys7Ci0JCQkJdG1wID0gcGd0eXBl c19hbGxvYyhzdHJsZW4oIiVJOiVNOiVTICVwIikgKyBzdHJsZW4ocHN0cikgKyAxKTsKKwkJCQl0 bXAgPSBwZ3R5cGVzX2FsbG9jKHN0cmxlbigiJUk6JU06JVMgJXAiKSArIHN0cmxlbihwZm10KSAr IDEpOwogCQkJCWlmICghdG1wKQogCQkJCQlyZXR1cm4gMTsKIAkJCQlzdHJjcHkodG1wLCAiJUk6 JU06JVMgJXAiKTsKQEAgLTI3OTUsNyArMjc5NSw3IEBAIFBHVFlQRVN0aW1lc3RhbXBfZGVmbXRf c2NhbihjaGFyICoqc3RyLCBjaGFyICpmbXQsIHRpbWVzdGFtcCAqIGQsCiAJCQkJcmV0dXJuIGVy cjsKIAkJCWNhc2UgJ1InOgogCQkJCXBmbXQrKzsKLQkJCQl0bXAgPSBwZ3R5cGVzX2FsbG9jKHN0 cmxlbigiJUg6JU0iKSArIHN0cmxlbihwc3RyKSArIDEpOworCQkJCXRtcCA9IHBndHlwZXNfYWxs b2Moc3RybGVuKCIlSDolTSIpICsgc3RybGVuKHBmbXQpICsgMSk7CiAJCQkJaWYgKCF0bXApCiAJ CQkJCXJldHVybiAxOwogCQkJCXN0cmNweSh0bXAsICIlSDolTSIpOwpAQCAtMjg0Miw3ICsyODQy LDcgQEAgUEdUWVBFU3RpbWVzdGFtcF9kZWZtdF9zY2FuKGNoYXIgKipzdHIsIGNoYXIgKmZtdCwg dGltZXN0YW1wICogZCwKIAkJCQlicmVhazsKIAkJCWNhc2UgJ1QnOgogCQkJCXBmbXQrKzsKLQkJ CQl0bXAgPSBwZ3R5cGVzX2FsbG9jKHN0cmxlbigiJUg6JU06JVMiKSArIHN0cmxlbihwc3RyKSAr IDEpOworCQkJCXRtcCA9IHBndHlwZXNfYWxsb2Moc3RybGVuKCIlSDolTTolUyIpICsgc3RybGVu KHBmbXQpICsgMSk7CiAJCQkJaWYgKCF0bXApCiAJCQkJCXJldHVybiAxOwogCQkJCXN0cmNweSh0 bXAsICIlSDolTTolUyIpOwpkaWZmIC0tZ2l0IGEvc3JjL2ludGVyZmFjZXMvZWNwZy90ZXN0L3Bn dHlwZXNsaWIvZHRfdGVzdDIucGdjIGIvc3JjL2ludGVyZmFjZXMvZWNwZy90ZXN0L3BndHlwZXNs aWIvZHRfdGVzdDIucGdjCmluZGV4IDYyYjkzNGIwN2VlLi4xMDFmY2NjZTZhOCAxMDA2NDQKLS0t IGEvc3JjL2ludGVyZmFjZXMvZWNwZy90ZXN0L3BndHlwZXNsaWIvZHRfdGVzdDIucGdjCisrKyBi L3NyYy9pbnRlcmZhY2VzL2VjcGcvdGVzdC9wZ3R5cGVzbGliL2R0X3Rlc3QyLnBnYwpAQCAtNjYs NiArNjYsMTIgQEAgbWFpbih2b2lkKQogCQlkYXRlICpkYzsKIAlleGVjIHNxbCBlbmQgZGVjbGFy ZSBzZWN0aW9uOwogCisJY2hhciBsYXJnZV9mbXRbMTAwMDBdID0geworCQlbMF0gPSAnJScsCisJ CVsxXSA9ICdEJywKKwkJWzIgLi4uIDk5OThdID0gJ0EnCisJfTsKKwogCWludCBpLCBqOwogCWNo YXIgKmVuZHB0cjsKIApAQCAtMTQ3LDUgKzE1Myw4IEBAIG1haW4odm9pZCkKIAkJUEdUWVBFU2lu dGVydmFsX2ZyZWUoaTEpOwogCX0KIAorCVBHVFlQRVN0aW1lc3RhbXBfZGVmbXRfYXNjKCIxIG1p bnV0ZSIsIGxhcmdlX2ZtdCwgJnRzMSk7CisJcHJpbnRmKCJTdWNjZXNzIHBhcnNpbmcgbGFyZ2Ug c3RyaW5nXG4iKTsKKwogCXJldHVybiAwOwogfQotLSAKMi40My4wCgo= --_002_f159cf94e6694f11af783616234683dcftdataru_--