Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEBX8-00012n-Bw for pgsql-hackers@arkaria.postgresql.org; Mon, 22 Feb 2021 13:45:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lEBX6-0005BZ-57 for pgsql-hackers@arkaria.postgresql.org; Mon, 22 Feb 2021 13:45:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEBX5-0005BS-UR for pgsql-hackers@lists.postgresql.org; Mon, 22 Feb 2021 13:45:51 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEBX2-0001ni-Rd for pgsql-hackers@postgresql.org; Mon, 22 Feb 2021 13:45:50 +0000 X-Originating-IP: 79.88.149.14 Received: from [172.16.255.146] (14.149.88.79.rev.sfr.net [79.88.149.14]) (Authenticated sender: vik@postgresfriends.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 005C5E0014; Mon, 22 Feb 2021 13:45:45 +0000 (UTC) Subject: Re: SEARCH and CYCLE clauses To: Peter Eisentraut , pgsql-hackers References: <54e533c5-09e5-7f41-9892-d4e0f7c62598@postgresfriends.org> <1cfc9079-9595-d167-00e6-5014438cc3e2@2ndquadrant.com> <9ce4d370-048c-1d67-fffb-a86f17120132@postgresfriends.org> <3c931f0f-6f53-598d-702f-1e6e932690ab@2ndquadrant.com> <82b6e6ca-e138-81a6-673d-20cfbdc4ec3e@postgresfriends.org> <3e092df8-3844-2d29-beb5-16c866554936@2ndquadrant.com> From: Vik Fearing Message-ID: Date: Mon, 22 Feb 2021 14:45:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <3e092df8-3844-2d29-beb5-16c866554936@2ndquadrant.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2/22/21 1:28 PM, Peter Eisentraut wrote: > On 22.02.21 11:05, Vik Fearing wrote: >> This looks good to me, except that you forgot to add the feature stamp. >>   Attached is a small diff to apply on top of your patch to fix that. > > The feature code is from SQL:202x, whereas the table is relative to > SQL:2016.  We could add it, but probably with a comment. OK. -- Vik Fearing