Message-ID: <f1b24ec2-9b36-90f3-8c58-83c70991f9d8@xs4all.nl>
Date: Fri, 22 Sep 2023 10:23:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: Row pattern recognition
Content-Language: en-US
To: Tatsuo Ishii <ishii@sraoss.co.jp>, vik@postgresfriends.org
Cc: pgsql-hackers@postgresql.org
References: <CAAWbhmjq3NY1+Am-QHJ4AFh7mi=2eiiGqj518f3-j-C3EfffPg@mail.gmail.com>
 <20230912.151843.1810014897541305662.t-ishii@sranhm.sra.co.jp>
 <20230912.174457.1842965393591953201.t-ishii@sranhm.sra.co.jp>
 <20230922.141640.288673971790249857.t-ishii@sranhm.sra.co.jp>
From: Erik Rijkers <er@xs4all.nl>
In-Reply-To: <20230922.141640.288673971790249857.t-ishii@sranhm.sra.co.jp>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/f1b24ec2-9b36-90f3-8c58-83c70991f9d8%40xs4all.nl>
Precedence: bulk

Op 9/22/23 om 07:16 schreef Tatsuo Ishii:
>> Attached is the fix against v6 patch. I will include this in upcoming v7 patch.
> 
> Attached is the v7 patch. It includes the fix mentioned above.  Also
(Champion's address bounced; removed)

Hi,

In my hands, make check fails on the rpr test; see attached .diff file.
In these two statements:
-- using NEXT
-- using AFTER MATCH SKIP TO NEXT ROW
   result of first_value(price) and next_value(price) are empty.

Erik Rijkers


> this time the pattern matching engine is enhanced: previously it
> recursed to row direction, which means if the number of rows in a
> frame is large, it could exceed the limit of stack depth.  The new
> version recurses over matched pattern variables in a row, which is at
> most 26 which should be small enough.
> 
> Best reagards,
> --
> Tatsuo Ishii
> SRA OSS LLC
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp