Feedback-ID: i131946ab:Fastmail
Message-ID: <f242cb2a-66d2-1ac2-d76e-1638ec9cc26d@enterprisedb.com>
Date: Tue, 1 Nov 2022 12:20:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH] Improve tab completion for ALTER TABLE on identity
 columns
Content-Language: en-US
To: Matheus Alcantara <mths.dev@pm.me>,
 =?UTF-8?Q?Dagfinn_Ilmari_Manns=c3=a5ker?= <ilmari@ilmari.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <87mta1jfax.fsf@wibble.ilmari.org>
 <O6GB3SIM-aNw1FgXVh0AcY-5sOsKOQrbDiBoXZxfYqP0uSQTfr87xf1nd6Lp9fWMad_1P7g0GQu-UqM_106PMpR_VsVFXGKi2CNmVzxZTXg=@pm.me>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <O6GB3SIM-aNw1FgXVh0AcY-5sOsKOQrbDiBoXZxfYqP0uSQTfr87xf1nd6Lp9fWMad_1P7g0GQu-UqM_106PMpR_VsVFXGKi2CNmVzxZTXg=@pm.me>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/f242cb2a-66d2-1ac2-d76e-1638ec9cc26d%40enterprisedb.com>
Precedence: bulk

On 26.10.22 00:45, Matheus Alcantara wrote:
>> I noticed that psql has no tab completion around identity columns in
>> ALTER TABLE, so here's some patches for that.
>>
>> In passing, I also added completion for ALTER SEQUECNE … START, which was
>> missing for some reason.

> I've tested all 4 of your patches, and all of them seem to work as expected.
> 
> This is my first time reviewing a patch, so let's see if more experience
> hackers has anything more to say about these patches, but at first they
> seem correct to me.

This was sensible for a first review.  Thanks for you help.