Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i1oFn-0005B7-PC for pgsql-hackers@arkaria.postgresql.org; Sun, 25 Aug 2019 08:52:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i1oFm-0005vX-EX for pgsql-hackers@arkaria.postgresql.org; Sun, 25 Aug 2019 08:52:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i1oFl-0005vN-Ev for pgsql-hackers@lists.postgresql.org; Sun, 25 Aug 2019 08:52:02 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i1oFd-0001nO-KJ for pgsql-hackers@postgresql.org; Sun, 25 Aug 2019 08:52:00 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 3E22B4BC for ; Sun, 25 Aug 2019 04:51:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 25 Aug 2019 04:51:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=Pm9yWe0F77U2Wb4FlgYLppjVFbPlM 1gz+MblSSF5Sic=; b=DVbI7NmXcEzaqTCIIO57RXRlzWaTUXBfq7bW/uQOG5mbs Qkz0nlW6g4jNVU2eRo291lpclBjjwt2aPb9Wjh5r/JsS9yBc+o1dOtdG161FmpG5 lSTBFt8o6Urd7D/LRsSh0RZNpW2pFIUHVtljE7Cp90cc+J2FZFx5/EBS89bWwvNL a8NfiFiUNY8ohSNRUsOPPl9AQUd4VNhyvJ6ITkfs814Pmk9IEQXHkaPw/owCSWqa Qb/gafeN5VdHMx6jw2f4D//lI7Z13P2RQEfH3yET35Cr77XxCmreruXDFj11pIhY 3QRshjLTcfZp0Cir41R23fKvBRGrLfB8If6SFE8xg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudehvddgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefvhffuohfkffgfgggtsehmtderre dtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgv ihhsvghnthhrrghuthesvdhnughquhgrughrrghnthdrtghomheqnecuffhomhgrihhnpe dvnhguqhhurggurhgrnhhtrdgtohhmpdhpohhsthhgrhgvshhqlhdrohhrghenucfkphep leefrddvgedvrdegtddrvddtvdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrh drvghishgvnhhtrhgruhhtsedvnhguqhhurggurhgrnhhtrdgtohhmnecuvehluhhsthgv rhfuihiivgeptd X-ME-Proxy: Received: from april.pezone.net (p5df228ca.dip0.t-ipconnect.de [93.242.40.202]) by mail.messagingengine.com (Postfix) with ESMTPA id F05B48005C for ; Sun, 25 Aug 2019 04:51:48 -0400 (EDT) To: pgsql-hackers From: Peter Eisentraut Subject: pg_upgrade: Error out on too many command-line arguments Openpgp: preference=signencrypt Autocrypt: addr=peter.eisentraut@2ndquadrant.com; prefer-encrypt=mutual; keydata= xsFNBFUUt6kBEADZd9NNTBJbHmAXXJgPGOdd6Q73l80oifIVgn2tRxP9dYkCfTlo/yLqbKTl JNqTcyM6XrJDnB2sMEUGYCewYZXl+9C4bBJWyNqcEI1ae9u71vEq/fknFLArJ+2wN+f7QuRx Q8d94ZJAiJQ5g3fNk2HVeedCQCKP5dCzU+ZLt2dbsx1PDZLjTO9gf+JswWuGFb5wY5PZVM5V hq66Xk7ZJzHuARacza2RT7J2fkMmQBY+kr7L98Perb0GhafnlhXB0PvUB+N3xpmggMfwuhTu BngS/G/r3GvemxJuFxouw8xsMqrsfdksJXA2gLXYtwRCssdPV3PO0rlD9twqDo8URfIJ5fb6 1g/MV8aTOKjg3Q8MpJPtkwJqN4o3PvbwYdedeFnOVkkYAJdu/aX1v1BeCBDu7Hy3sF52scD3 pQbyQSl9vUDpTLarASAxNbAV0NRJE8dp4vfW6AH1ccryGiFqw/czPK/iN0+MT8wsjAW6WW4w hvjm5UPA1KTwi3ZT8eT5uycuH7QpuNk7LnGGXQ6KaRALFywzkr0A0V0AvFNa+l4wstMaXaB6 dmMXyF0/hfryqyOeu1gAdq4q0/PNC2dPgb/6uoh4eMjN6A5GXcprilhz5DulmsilY21hfSoU S64ODed96pKhprsOxjZiDRsN1QM5MwB+uwVWUNfsX7fIxE0BrwARAQABzSdQZXRlciBFaXNl bnRyYXV0IDxwZXRlckBlaXNlbnRyYXV0Lm9yZz7CwXoEEwEIACQCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AFAlUUuKQCGQEACgkQoZ8SQ+xBJp8llw//RbGoXnF72FZTlOFsnNyxnWbF vViPCfdAlZl1GGK9OYCvV1dp/956HuhB0wpaGQHiBmQfOPJf/jLOPjXFYm2iEChEycrBChuE j4TSYemMp5BSPILYk9Uwd16kVD/+U6fQfK6H5pOhfBvbM6asMnmpY2wQuvktxHvaGlytFw84 EzFWNZtAZfxkw28w3AhIQkKe9hJanfyDL750RcbyEr8AAHty5IErrvS7tM5vQwIeh5BF26ND CyKPRdZgOgMpcwFfROKBDpAt052CgWIpNdhBdfIKlkCs4/ILxmC3rT/Mb/qZiHcoMMwEu6k+ T7vRAFZZAk62Yrr/U8/vUGKlzRZQoo86fyojCfI0ibCIc0z8rwCVY9P40G9wD9BTCZS/z8Vh jjpBlNnIKw2hM6hbxavKndCJjFFJD08rXrTyrLF/of18xD37vNdYooP9VATB5QjOWFRrscSZ 4a89e+to3m7YVnd4xdXwGp47dYusoax84C8tg1gZrH38ol9dPmnKX6GZrXeS7tH9k8VeUpJ8 HQbRThQRWAT936QpYbLConBmOtmbLmjQOGtiXPo1oK57X/7U/WBja5vWmm2q+Yxtt+3uHGVg DdDU4CJpXo4lX0v2n3QV5EBSW9hjdF3bNfl6GFBb1pPEhqNcMDUc7zkx/2uENdAdk/BnqMgH umip7b0pVfvOwU0EVRS3qQEQAJf6p0P7D+hMYUgCPkvgrcz6OJYsAYdUMUmokfqmkKwK0oJM ew8TNGM53ocKAgQGma5f10rwbZNPlpVPNRX5hwUmwVlcwSut0oE+JfUBH7mpysWvpF05RKIy q9RCoJZrAbXS7Tig56A1QD8IcM00rERZMcCOlI1+q9m4u9AOI+0LyGGSH+VvoyDHD/Jew4R2 TmPEF8Pu7lYiNYK88Q6u0kBkc+Tz3BNlyc6fi3HxnFfp0b75HLXPSTu2SwA/0Q31wHZXwrEU BR9KgSn/qbgy8ydPc97i82fhiFE3cbGexfPrQSMYmDGi+dcQ0s+AMQwC3XyMC0JkHpYUuFkR QdlIvaIhgFUUN2Vr4xF2ADaNTNFc4DYaiPHFAgHZw+3pZWqS4uIiWgJynrEaHw4F3QWU8/JB iyEWDhNq4WBrRA0u914TCCAoFOOKMnRdl8eJrRQKM/5/lXbHFjjlI/LDKhLRFsuQsnJJ3331 RjCzpHPZG5/p5KR1RHiAXa0p/DW5lXyq21hS3kjDlleoHqOxCN/cy0Jgz7qLDq1vZoCl67Sy RAH60c2Xu4may9SVltmot0OzWVHdrfS+85FQGp9580DaeLio7YMFKy2bfEvwQJ/c9xD2QPB+ oSb3V8ueSznXBG5+dyfOsZFRPxceA0wA2rSWZSjxLdKxvyGTj9vsCjaDu13rABEBAAHCwV8E GAEIAAkFAlUUt6kCGwwACgkQoZ8SQ+xBJp+HJhAAxmSTsC5y7p9Zu+nnLpucv/h88oEx985e qWeXzQiwM3pfRZS+PdTH9TyzHK0KOgKoAiubk0vt+BrT91D9d0G5kVQaTctAErGBoMkTaZJT XVEcNphiPzysdSqvprjojMp1y7rG8AP+Xd6m0rE1LRnkRRm8HyI8vdXsuLQPITGWXDLMjaNq AOV3BUnzkgtjMuIYw7SCr+12ZOb5dEKvaG4kjC4kaJ/TLbuBhVANcXkC90yp0AOZLs/cB1Dj OAXno/RUUruJ3r27a+pFv768UAi9QWcdw58yPxreMNMLqAgsS9oTHwHfGNWcB2dJ4UW+GMLJ hTf9TjQ2f+N/sIx5XMQ9pYw6CAJMK29qPx6/ZayrPxf22EXf0D3zTwIEZgwfSkynFVwV25L7 awQq60fifdMYheSxq7GbhpsixmcD+e161cCmLIt75YDt5bQ0B1yf7EmxG8n7pGZAOM6LoNsU fkSldba5XVwh8LuN5mK0nQBELGW6Os4TDq4REggLpfcvFC215zpuo0iCGnmE/Bns4nowqUSP u4tkWL+nxW4qgv8wo8HJ52jd79EJ8iqfIBoidBfy9AIUiEUApGQzWPu6yWcI8fY0rN5D+tc+ Yw1Zt6Mm+huYJpgCRsTcfzEcahnBn521CWcWvhW1ff3KFileFMtNmnBBhMncmRKHphtTKEpN 3jI= Organization: 2ndQuadrant Message-ID: Date: Sun, 25 Aug 2019 10:51:47 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------034E880416514236FADD3D0F" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------034E880416514236FADD3D0F Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit I propose the attached patch to make pg_upgrade error out on too many command-line arguments. This makes it match the behavior of other PostgreSQL programs. See [0] for an issue related to the lack of this check: [0]: https://www.postgresql.org/message-id/871sdbzizp.fsf%40jsievers.enova.com -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --------------034E880416514236FADD3D0F Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="0001-pg_upgrade-Error-out-on-too-many-command-line-argume.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-pg_upgrade-Error-out-on-too-many-command-line-argume.pa"; filename*1="tch" RnJvbSA2NGJiYjU2MmI5MGJkNjI3Mjk4OGM2MDg1MjRkYTIzMzkzMjNmMTE0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogU3VuLCAyNSBBdWcgMjAxOSAxMDo0NjowNyArMDIwMApTdWJqZWN0 OiBbUEFUQ0hdIHBnX3VwZ3JhZGU6IEVycm9yIG91dCBvbiB0b28gbWFueSBjb21tYW5kLWxp bmUgYXJndW1lbnRzCgpUaGlzIG1ha2VzIGl0IG1hdGNoIHRoZSBiZWhhdmlvciBvZiBvdGhl ciBQb3N0Z3JlU1FMIHByb2dyYW1zLgoKcGdfdXBncmFkZSBkb2Vzbid0IHRha2UgYW55IG5v bi1vcHRpb24gYXJndW1lbnRzLCBzbyB0aGVzZSBhcmUgYWx3YXlzCmEgbWlzdGFrZS4KLS0t CiBzcmMvYmluL3BnX3VwZ3JhZGUvb3B0aW9uLmMgfCAzICsrKwogMSBmaWxlIGNoYW5nZWQs IDMgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfdXBncmFkZS9vcHRp b24uYyBiL3NyYy9iaW4vcGdfdXBncmFkZS9vcHRpb24uYwppbmRleCBlNDA5M2VkNWFmLi42 YWZkYmVhYmM4IDEwMDY0NAotLS0gYS9zcmMvYmluL3BnX3VwZ3JhZGUvb3B0aW9uLmMKKysr IGIvc3JjL2Jpbi9wZ191cGdyYWRlL29wdGlvbi5jCkBAIC0yMTgsNiArMjE4LDkgQEAgcGFy c2VDb21tYW5kTGluZShpbnQgYXJnYywgY2hhciAqYXJndltdKQogCQl9CiAJfQogCisJaWYg KG9wdGluZCA8IGFyZ2MpCisJCXBnX2ZhdGFsKCJ0b28gbWFueSBjb21tYW5kLWxpbmUgYXJn dW1lbnRzIChmaXJzdCBpcyBcIiVzXCIpXG4iLCBhcmd2W29wdGluZF0pOworCiAJaWYgKChs b2dfb3B0cy5pbnRlcm5hbCA9IGZvcGVuX3ByaXYoSU5URVJOQUxfTE9HX0ZJTEUsICJhIikp ID09IE5VTEwpCiAJCXBnX2ZhdGFsKCJjb3VsZCBub3Qgb3BlbiBsb2cgZmlsZSBcIiVzXCI6 ICVtXG4iLCBJTlRFUk5BTF9MT0dfRklMRSk7CiAKLS0gCjIuMjIuMAoK --------------034E880416514236FADD3D0F--