Message-ID: <f27eb58b410e2eb14cddcefeba67dcf1d57968ea.camel@j-davis.com>
Subject: Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX
From: Jeff Davis <pgsql@j-davis.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Ted Yu <yuzhihong@gmail.com>,
 Pavel Luzanov <p.luzanov@postgrespro.ru>, Justin Pryzby
 <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org
Date: Wed, 21 Jun 2023 09:29:54 -0700
In-Reply-To: <20230620225257.GA771663@nathanxps13>
References: <20230613211246.GA219055@nathanxps13>
	 <ZIj4v1CwqlDVJZfB@paquier.xyz> <20230613235442.GA222795@nathanxps13>
	 <20230614181711.GA488295@nathanxps13> <ZIpfack6qJUHaw+g@paquier.xyz>
	 <20230615041044.GA736001@nathanxps13> <20230615235700.GA877311@nathanxps13>
	 <20230616052025.GA1026700@nathanxps13>
	 <20230619215534.GA442477@nathanxps13>
	 <edf8dc01333f4b3355aa91001cb26029cab1eb2e.camel@j-davis.com>
	 <20230620225257.GA771663@nathanxps13>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/f27eb58b410e2eb14cddcefeba67dcf1d57968ea.camel%40j-davis.com>
Precedence: bulk

On Tue, 2023-06-20 at 15:52 -0700, Nathan Bossart wrote:
> At the moment, I think I'm inclined to call this "existing behavior"
> since
> we didn't check privileges for each partition in this case even
> before
> MAINTAIN was introduced.=C2=A0 IIUC we still process the individual
> partitions
> in v15 regardless of whether the calling user owns the partition.

That's fine with me. I just wanted to bring it up in case someone else
thought it was a problem.

> However, I do agree that it feels inconsistent.=C2=A0 Besides the options
> you
> proposed, we might also consider making REINDEX work a bit more like
> VACUUM
> and ANALYZE and emit a WARNING for any relations that the user is not
> permitted to process.=C2=A0 But this probably deserves its own thread, an=
d
> it
> might even need to wait until v17.

Yes, we can revisit for 17.

Regards,
	Jeff Davis