Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZDuK-0004Yp-FX for pgsql-hackers@arkaria.postgresql.org; Wed, 21 Apr 2021 14:32:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lZDuJ-00082V-Ds for pgsql-hackers@arkaria.postgresql.org; Wed, 21 Apr 2021 14:32:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZDuJ-00082J-77 for pgsql-hackers@lists.postgresql.org; Wed, 21 Apr 2021 14:32:47 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZDuG-0001PX-Qu for pgsql-hackers@lists.postgresql.org; Wed, 21 Apr 2021 14:32:46 +0000 X-Originating-IP: 99.10.92.30 Received: from [192.168.10.146] (99-10-92-30.lightspeed.rlghnc.sbcglobal.net [99.10.92.30]) (Authenticated sender: adsend@dunslane.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id EF82CE0013; Wed, 21 Apr 2021 14:32:41 +0000 (UTC) Subject: Re: Free port choosing freezes when PostgresNode::use_tcp is used on BSD systems To: Alexey Kondratov , Tom Lane Cc: pgsql-hackers@lists.postgresql.org References: <20210127213658.GA736@alvherre.pgsql> <55c6c1526b94d2caf54c33262fe00674@postgrespro.ru> <1c506564e2a732ec17790bd8c34f042e@postgrespro.ru> <66bad38beb87fb32952d89602e467444@postgrespro.ru> <82e271a9a11928337fcb5b5e57b423c0@postgrespro.ru> <459595.1618874567@sss.pgh.pa.us> <519ddb94-f3ac-e9cc-3a61-7003c26f62f8@dunslane.net> <559792.1618931011@sss.pgh.pa.us> <3cba5930342a51665e6959002cedb4d9@postgrespro.ru> From: Andrew Dunstan Message-ID: Date: Wed, 21 Apr 2021 10:32:40 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <3cba5930342a51665e6959002cedb4d9@postgrespro.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 4/20/21 6:49 PM, Alexey Kondratov wrote: > On 2021-04-20 18:03, Tom Lane wrote: >> Andrew Dunstan writes: >>> On 4/19/21 7:22 PM, Tom Lane wrote: >>>> I wonder whether we could get away with just replacing the $use_tcp >>>> test with $TestLib::windows_os.  It's not really apparent to me >>>> why we should care about 127.0.0.not-1 on Unix-oid systems. >> >>> Yeah >>> The comment is a bit strange anyway - Cygwin is actually going to use >>> Unix sockets, not TCP. >>> I think I would just change the test to this: $use_tcp && >>> $TestLib::windows_os. >> >> Works for me, but we need to revise the comment to match. >> > > Then it could be somewhat like that, I guess. > > > pushed with slight edits. Thanks. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com