Feedback-ID: ie0a040ee:Fastmail
Message-ID: <f2977de9-73fb-4ced-a759-b53cb42c98be@eisentraut.org>
Date: Fri, 24 Apr 2026 09:18:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Bug: pg_get_viewdef() fails on GRAPH_TABLE views with lateral
 column references
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CAHg+QDcLVa2iBnggkHxY4itZbXtDMfsYHEjnCUYe9hNbnxDi-w@mail.gmail.com>
 <CAExHW5tOhqm7U0Yvsj=aEQWefKnD-ijpT2YzCCrDNJYm=QQu2Q@mail.gmail.com>
 <CAHg+QDe2=EzNGraOnEMX6G2PYLp599JBXMMJT4gw6tJfFAsXcg@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAHg+QDe2=EzNGraOnEMX6G2PYLp599JBXMMJT4gw6tJfFAsXcg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/f2977de9-73fb-4ced-a759-b53cb42c98be%40eisentraut.org>
Precedence: bulk

On 21.04.26 10:02, SATYANARAYANA NARLAPURAM wrote:
>     The code doesn't explain why it adds the dummy context but it seemed
>     intentional. But it's not used at other places like deparsing WHERE
>     clause in element patterns or that in the graph_table itself. Since a
>     lateral reference is allowed in COLUMNS clause as well, it doesn't
>     make sense not to pass a context with lateral namespaces. Also there
>     is no comment explaining the dummy context. So your fix looks good to
>     me. I adjusted the surrounding code a bit.
> 
>     I adjusted an existing view for the testing instead of adding a new
>     one with all the additional objects. Since that view definition was
>     getting more complex, I formatted the DDL to be more readable.
> 
>     I also think that we should use prettyFlags to deparse all GRAPH_TABLE
>     components in a human readable form. But that's out of the scope for
>     this patch.
> 
>     PFA updated patch.
> 
> Thank you for updating the patch. It applies cleanly and the related 
> tests are passing.

committed