Message-ID: <f29ec4fc76af990119bdf45ef33d1282f9c19554.camel@j-davis.com>
Subject: Re: pg_dump --with-* options
From: Jeff Davis <pgsql@j-davis.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Peter Eisentraut
	 <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: Mon, 30 Jun 2025 13:28:14 -0700
In-Reply-To: 
 <CA+TgmoYW4ycbzZehdS9nOw60ZdtwzWZ-qoVpBe3+QCpeBxvKug@mail.gmail.com>
References: <7cc52488-f876-4ad3-affd-6e4b0ef0cb09@eisentraut.org>
	 <aEMLzPQtjRbj2R7X@nathan>
	 <CA+TgmoactJEUHeXuxHLKNXHzm6-XrQFigPur-4nHTMFSiSRkiQ@mail.gmail.com>
	 <aErpuM6RXSlK1FBW@nathan>
	 <7bf0246542713d80f12c738c1d365d1365750c18.camel@j-davis.com>
	 <5e398522803da9bf3f9fc33ca43084ec21ab0fcd.camel@j-davis.com>
	 <aFLenfMRS9jFINxq@nathan>
	 <031558c60e84362898922caa6a90587e7fdf2a57.camel@j-davis.com>
	 <CA+TgmoYW4ycbzZehdS9nOw60ZdtwzWZ-qoVpBe3+QCpeBxvKug@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.3-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/f29ec4fc76af990119bdf45ef33d1282f9c19554.camel%40j-davis.com>
Precedence: bulk

On Mon, 2025-06-23 at 13:38 -0400, Robert Haas wrote:


> What confuses me about what you've written here specifically is that
> pg_dump and pg_restore are different programs with different option
> sets. So when you say we need both --with-statistics and
> --no-statistics, I guess that's true, but we're not talking about the
> same executable in both cases. It seems to me that pg_restore should
> restore everything that was dumped, but that there should be (as
> there
> are) various --no-whatever switches to skip unwanted items. But
> pg_dump should have dump a reasonable set of things by default, and
> the user should be able to add to that or subtract from it.

True, we could have different options for pg_dump and pg_restore, but
to me that seems a little strange because so many of the other options
overlap. I figured that would be confusing, but maybe it's fine.

Regards,
	Jeff Davis