Message-ID: <f2b2481d-f017-b005-d2c6-e1ff0f611353@yandex.ru>
Date: Fri, 23 Sep 2022 12:43:19 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: RFC: Logging plan of the running query
Content-Language: en-US
To: torikoshia <torikoshia@oss.nttdata.com>
References: <20220202.170421.204740592565249296.horikyota.ntt@gmail.com>
 <3bb7bacbc5ef9e58e2ece0557adac98b@oss.nttdata.com>
 <03c8dcbb-72d2-d3ad-3ad1-9efe69676529@oss.nttdata.com>
 <20220208.171852.1699766364147189900.horikyota.ntt@gmail.com>
 <ab761e68f3fbcee80cf1ca19b1db85f1@oss.nttdata.com>
 <3e94e9b3-83ef-c328-0c5c-f93aa3224790@oss.nttdata.com>
 <3d121ed5f81cef588bac836b43f5d1f9@oss.nttdata.com>
 <379d69c0b3d058997550f88e73ffddd6@oss.nttdata.com>
 <727712bcaa8d449615820c16d15e452e@oss.nttdata.com>
 <598171663576373@mail.yandex.ru>
 <38f4e19323b264e5975c60010b512b15@oss.nttdata.com>
 <d4a5ea75-d6a3-7f02-890e-8e3d1a43aeab@yandex.ru>
 <0cc0608d89cc61a29e18c4ba8f8a03a6@oss.nttdata.com>
From: Alena Rybakina <lena.ribackina@yandex.ru>
Cc: pgsql-hackers@lists.postgresql.org
In-Reply-To: <0cc0608d89cc61a29e18c4ba8f8a03a6@oss.nttdata.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/f2b2481d-f017-b005-d2c6-e1ff0f611353%40yandex.ru>
Precedence: bulk

Sorry, I wrote confusingly at that time.

No, I suggested adding comment about the explanation of 
HandleLogQueryPlanInterrupt() only in the explain.h and not removing 
from the explain.c.

I seemed to be necessary separating declaration function for 'explaining 
feature' of executed query from our logging plan of the running query 
interrupts function. But now, I doubt it.

> I'm not sure I understand your comment correctly, do you mean 
> HandleLogQueryPlanInterrupt() should not be placed in explain.c? 


Thank you for having reminded about this function and I looked at 
ProcessLogMemoryContextInterrupt() declaration. I'm noticed comments in 
the memutils.h are missed tooю

Description of this function is written only in mcxt.c.
> However, given that ProcesLogMemoryContextInterrupt(), which similarly 
> handles interrupts for pg_log_backend_memory_contexts(), is located in 
> mcxt.c, I also think current location might be acceptable. 


So I think you are right and the comment about the explanation of 
HandleLogQueryPlanInterrupt() written in explain.h is redundant.

> I feel this comment is unnecessary since the explanation of 
> HandleLogQueryPlanInterrupt() is written in explain.c and no functions 
> in explain.h have comments in it. 

Regards,

-- 
Alena Rybakina
Postgres Professional