Content-Type: multipart/alternative;
 boundary="------------ZEIF8zTTY8yuoHzkjwx8Dq69"
Message-ID: <f34b2134-85d6-4615-8f3f-e29a2f6f04ab@postgrespro.ru>
Date: Thu, 8 Feb 2024 14:01:55 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Psql meta-command conninfo+
Content-Language: en-US, ru-RU
To: Maiquel Grassi <grassi@hotmail.com.br>,
 Nathan Bossart <nathandbossart@gmail.com>
Cc: Erik Wienhold <ewie@ewie.name>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <CP8P284MB24965CB63DAC00FC0EA4A475EC462@CP8P284MB2496.BRAP284.PROD.OUTLOOK.COM>
 <20240206181919.GA3853632@nathanxps13>
 <aevq2dxmw2xm2rc3nh2wdcozunipco447mf4rpm7efvqvz4wk2@mo3zmf2ulbzu>
 <CP8P284MB2496B51FC5ED9BD6527D459DEC462@CP8P284MB2496.BRAP284.PROD.OUTLOOK.COM>
 <20240206210605.GA3903769@nathanxps13> <20240206211205.GA3903996@nathanxps13>
 <CP8P284MB24965479BA59DF5C2CC01CA0EC462@CP8P284MB2496.BRAP284.PROD.OUTLOOK.COM>
 <20240206215022.GA3452@nathanxps13>
 <CP8P284MB2496A17A9852265A0F363A6AEC452@CP8P284MB2496.BRAP284.PROD.OUTLOOK.COM>
 <852cabef-f596-4826-9a54-d3f75d9a6cc8@postgrespro.ru>
 <CP8P284MB24961361A9C1D32C28A7EC0EEC452@CP8P284MB2496.BRAP284.PROD.OUTLOOK.COM>
 <e289dada-543d-495f-9cd3-5783a8412bc0@postgrespro.ru>
 <CP4P284MB24830F5BF17FFA7F3D733142EC452@CP4P284MB2483.BRAP284.PROD.OUTLOOK.COM>
From: Pavel Luzanov <p.luzanov@postgrespro.ru>
In-Reply-To: <CP4P284MB24830F5BF17FFA7F3D733142EC452@CP4P284MB2483.BRAP284.PROD.OUTLOOK.COM>
Archived-At: <https://www.postgresql.org/message-id/f34b2134-85d6-4615-8f3f-e29a2f6f04ab%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------ZEIF8zTTY8yuoHzkjwx8Dq69
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 07.02.2024 23:13, Maiquel Grassi wrote:

> Regarding the "system_user" function, as it is relatively new, I added 
> the necessary handling to avoid conflicts with versions lower than 
> version 16.
>
Yes, that's rights.

A couple of doubts about the implementation details.
But keep in mind that I'm not very good at programming in the C language.
I hope for the help of more experienced developers.


1.
+			if (db == NULL)
+				printf(_("You are currently not connected to a database.\n"));

This check is performed for \conninfo, but not for \conninfo+.


2.
Some values (address, socket) are evaluated separately for \conninfo
(via C functions) and for \conninfo+ (via sql functions).
It may be worth evaluating them in one place. But I'm not sure about that.

The final version of the patch will require changes to the documentation and tests.

-- 
Pavel Luzanov
Postgres Professional:https://postgrespro.com

--------------ZEIF8zTTY8yuoHzkjwx8Dq69
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <pre>Hi,

</pre>
    <div class="moz-cite-prefix">
      <pre>On 07.02.2024 23:13, Maiquel Grassi wrote:
<style type="text/css" style="display:none;">P {margin-top:0;margin-bottom:0;}</style></pre>
    </div>
    <blockquote type="cite"
cite="mid:CP4P284MB24830F5BF17FFA7F3D733142EC452@CP4P284MB2483.BRAP284.PROD.OUTLOOK.COM">
      <pre><p class="elementToProof"
      style="margin-top: 0px; margin-bottom: 0px;"><span
      style="font-size: 12pt; color: rgb(0, 0, 0);">Regarding the "system_user" function, as it is relatively new, I added
the necessary handling to avoid conflicts with versions lower than version 16.
</span></p></pre>
    </blockquote>
    <pre>
Yes, that's rights.

A couple of doubts about the implementation details.
But keep in mind that I'm not very good at programming in the C language.
I hope for the help of more experienced developers.


1.
+			if (db == NULL)
+				printf(_("You are currently not connected to a database.\n"));

This check is performed for \conninfo, but not for \conninfo+.


2.
Some values (address, socket) are evaluated separately for \conninfo
(via C functions) and for \conninfo+ (via sql functions).
It may be worth evaluating them in one place. But I'm not sure about that.

The final version of the patch will require changes to the documentation and tests.

</pre>
    <pre class="moz-signature" cols="72">-- 
Pavel Luzanov
Postgres Professional: <a class="moz-txt-link-freetext" href="https://postgrespro.com">https://postgrespro.com</a></pre>
  </body>
</html>

--------------ZEIF8zTTY8yuoHzkjwx8Dq69--