Subject: Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.
To: Shinya11.Kato@nttdata.com, david@pgmasters.net, movead.li@highgo.ca
Cc: pgsql-hackers@postgresql.org, andres@anarazel.de, michael@paquier.xyz,
 ahsan.hadi@highgo.ca, horikyota.ntt@gmail.com
References: <20201016.180033.217520066292592870.horikyota.ntt@gmail.com>
 <2020101617395691465546@highgo.ca>
 <240cd11dc6664dfcbef50c2d6b16ccb2@MP-MSGSS-MBX001.msg.nttdata.co.jp>
 <20201204.152047.1606427486743708152.horikyota.ntt@gmail.com>
 <b0a32c58414546b78b03f2c281f2f145@MP-MSGSS-MBX001.msg.nttdata.co.jp>
 <2021010611143203905334@highgo.ca>
 <066b8dd96b164ec2ac3af6cf6e33a0d5@MP-MSGSS-MBX001.msg.nttdata.co.jp>
 <fa69fe77-a64b-0207-fbd0-3d16b4940c95@pgmasters.net>
 <TYAPR01MB28966A71B35D1E22FE9450AFC4689@TYAPR01MB2896.jpnprd01.prod.outlook.com>
 <785ae632-3c4f-f291-d2b7-c2a08fab103b@oss.nttdata.com>
 <790571f2-7068-3717-6223-85683db74542@oss.nttdata.com>
 <OSBPR01MB28859FA68FC172FAEAA1C9DFC4659@OSBPR01MB2885.jpnprd01.prod.outlook.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <f3d945f2-fce5-5f43-6811-50ba2c8d69c4@oss.nttdata.com>
Date: Mon, 22 Mar 2021 14:07:43 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: 
 <OSBPR01MB28859FA68FC172FAEAA1C9DFC4659@OSBPR01MB2885.jpnprd01.prod.outlook.com>
Content-Type: multipart/mixed;
 boundary="------------BE2D45D10AE7811A7A716809"
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/f3d945f2-fce5-5f43-6811-50ba2c8d69c4%40oss.nttdata.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------BE2D45D10AE7811A7A716809
Content-Type: text/plain; charset=iso-2022-jp; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit


On 2021/03/22 14:03, Shinya11.Kato@nttdata.com wrote:
>> Barring any objection, I will commit this.
> 
> I think it's good except for a typo "thoes four bits"

Thanks for the review! Attached is the updated version of the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

--------------BE2D45D10AE7811A7A716809
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="fix_pg_waldump_xact_commit_record_stats_fujii_v2.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="fix_pg_waldump_xact_commit_record_stats_fujii_v2.patch"

ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfd2FsZHVtcC9wZ193YWxkdW1wLmMgYi9zcmMvYmlu
L3BnX3dhbGR1bXAvcGdfd2FsZHVtcC5jCmluZGV4IDYxMGY2NWU0NzEuLmY4YjhhZmU0YTcg
MTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcGdfd2FsZHVtcC9wZ193YWxkdW1wLmMKKysrIGIvc3Jj
L2Jpbi9wZ193YWxkdW1wL3BnX3dhbGR1bXAuYwpAQCAtNDM4LDYgKzQzOCwxNSBAQCBYTG9n
RHVtcENvdW50UmVjb3JkKFhMb2dEdW1wQ29uZmlnICpjb25maWcsIFhMb2dEdW1wU3RhdHMg
KnN0YXRzLAogCiAJcmVjaWQgPSBYTG9nUmVjR2V0SW5mbyhyZWNvcmQpID4+IDQ7CiAKKwkv
KgorCSAqIFhBQ1QgcmVjb3JkcyBuZWVkIHRvIGJlIGhhbmRsZWQgZGlmZmVyZW50bHkuIFRo
b3NlIHJlY29yZHMgdXNlIHRoZQorCSAqIGZpcnN0IGJpdCBvZiB0aG9zZSBmb3VyIGJpdHMg
Zm9yIGFuIG9wdGlvbmFsIGZsYWcgdmFyaWFibGUgYW5kIHRoZQorCSAqIGZvbGxvd2luZyB0
aHJlZSBiaXRzIGZvciB0aGUgb3Bjb2RlLiBXZSBmaWx0ZXIgb3Bjb2RlIG91dCBvZiB4bF9p
bmZvCisJICogYW5kIHVzZSBpdCBhcyB0aGUgaWRlbnRpZmllciBvZiB0aGUgcmVjb3JkLgor
CSAqLworCWlmIChybWlkID09IFJNX1hBQ1RfSUQpCisJCXJlY2lkICY9IDB4MDc7CisKIAlz
dGF0cy0+cmVjb3JkX3N0YXRzW3JtaWRdW3JlY2lkXS5jb3VudCsrOwogCXN0YXRzLT5yZWNv
cmRfc3RhdHNbcm1pZF1bcmVjaWRdLnJlY19sZW4gKz0gcmVjX2xlbjsKIAlzdGF0cy0+cmVj
b3JkX3N0YXRzW3JtaWRdW3JlY2lkXS5mcGlfbGVuICs9IGZwaV9sZW47Cg==
--------------BE2D45D10AE7811A7A716809--