Message-ID: <f3effc63-2d2d-59f5-3c87-7239b7c225bb@pgmasters.net>
Date: Tue, 5 Apr 2022 12:06:08 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: Postgres restart in the middle of exclusive backup and the
 presence of backup_label file
Content-Language: en-US
To: Stephen Frost <sfrost@snowman.net>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
 Chapman Flack <chap@anastigmatix.net>, Magnus Hagander
 <magnus@hagander.net>, pgsql-hackers@lists.postgresql.org
References: <62293417.8070104@anastigmatix.net>
 <20220310000622.GA225595@nathanxps13> <622A941A.90909@anastigmatix.net>
 <20220311003834.GA597706@nathanxps13>
 <20220328203027.GK10577@tamriel.snowman.net>
 <20220329020948.GA311150@nathanxps13>
 <17837e22-9b8d-f8d7-bc8b-7d3eaee3186b@pgmasters.net>
 <20220404142247.GA663209@nathanxps13> <20220404154218.GA792581@nathanxps13>
 <4c4ae416-be44-754e-7ee0-7083c11e7cfb@pgmasters.net>
 <20220405152536.GT10577@tamriel.snowman.net>
From: David Steele <david@pgmasters.net>
In-Reply-To: <20220405152536.GT10577@tamriel.snowman.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/f3effc63-2d2d-59f5-3c87-7239b7c225bb%40pgmasters.net>
Precedence: bulk

On 4/5/22 11:25 AM, Stephen Frost wrote:
> 
> Please find attached an updated patch + commit message.  Mostly, I just
> went through and did a bit more in terms of updating the documentation
> and improving the comments (there were some places that were still
> worrying about the chance of a 'stray' backup_label file existing, which
> isn't possible any longer), along with some additional testing and
> review.  This is looking pretty good to me, but other thoughts are
> certainly welcome.  Otherwise, I'm hoping to commit this tomorrow.

I have reviewed the changes and they look good. I also ran the new patch 
through pgbackrest regression with no issues.

Regards,
-- 
-David
david@pgmasters.net