Subject: Re: WIP: System Versioned Temporal Table
To: Surafel Temesgen <surafel3000@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: 
 <CALAY4q-cXCD0r4OybD=w7Hr7F026ZUY6=LMsVPUe6yw_PJpTKQ@mail.gmail.com>
 <3de42e96-45c3-faaa-af20-30f127724601@2ndquadrant.com>
 <CALAY4q9u4r_J-=v_MXJTpEx6WA=YhT3A3n9sw6P2XxK0rWk5bg@mail.gmail.com>
 <ab0b5380-cde4-607a-34f8-70082eba278b@2ndquadrant.com>
 <CALAY4q8xpuU7Qz7qy+5F8bh=GPAwR-pyscorAzTpyTQGyZbqtQ@mail.gmail.com>
 <55cf779b-a347-8c21-9a82-ad2030f95d0b@2ndquadrant.com>
 <CALAY4q8ETRoFLBR8qz1P=SNskBBW5z-Kr90t_XGrm9mc9zCEbQ@mail.gmail.com>
 <b11fa573-38fa-ba57-96a9-e4dd9ce3fb76@2ndquadrant.com>
 <CALAY4q_voAROyjHL0fidvfY7=GGERjqSf0r=uGwrJ-T_9-VBKg@mail.gmail.com>
 <9550e917-c370-36a3-277f-2f25bfc1b497@2ndquadrant.com>
 <CALAY4q88-1P1CWCJKEGHy1S3azG5g8cP_z_sEh+cd0G14YfmgA@mail.gmail.com>
From: Vik Fearing <vik.fearing@2ndquadrant.com>
Message-ID: <f3fb6bae-84b2-735a-20c8-b9918e62aaf3@2ndquadrant.com>
Date: Fri, 3 Jan 2020 14:22:34 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: 
 <CALAY4q88-1P1CWCJKEGHy1S3azG5g8cP_z_sEh+cd0G14YfmgA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

On 03/01/2020 11:57, Surafel Temesgen wrote:
>
>
> On Thu, Jan 2, 2020 at 12:12 AM Vik Fearing
> <vik.fearing@2ndquadrant.com <mailto:vik.fearing@2ndquadrant.com>> wrote:
>
>     This does not compile against current head (0ce38730ac).
>
>
>     gram.y: error: shift/reduce conflicts: 6 found, 0 expected
>
>
> Rebased and conflict resolved i hope it build clean this time
>

It does but you haven't included your tests file so `make check` fails.


It seems clear to me that you haven't tested it at all anyway.  The
temporal conditions do not return the correct results, and the syntax is
wrong, too.  Also, none of my previous comments have been addressed
except for "system versioning" instead of "system_versioning".  Why?

-- 

Vik Fearing