To: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
From: "Andrey V. Lepikhov" <a.lepikhov@postgrespro.ru>
Subject: Extra code in commit_ts.h
Organization: Postgres Professional
Message-ID: <f49aefb5-edbb-633a-af07-3e777023a94d@postgrespro.ru>
Date: Tue, 3 Aug 2021 14:36:34 +0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------21632BCF87EFC95614779452"
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/f49aefb5-edbb-633a-af07-3e777023a94d%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------21632BCF87EFC95614779452
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

I found two extra code lines in commit_ts.h (see attachment).
They confused me during exploring of the code. If they still needed, may 
be add some comments?

-- 
regards,
Andrey Lepikhov
Postgres Professional

--------------21632BCF87EFC95614779452
Content-Type: text/x-patch; charset=UTF-8;
 name="excess_code.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="excess_code.patch"

diff --git a/src/include/access/commit_ts.h b/src/include/access/commit_ts.h
index e045dd416f..a1538978c6 100644
--- a/src/include/access/commit_ts.h
+++ b/src/include/access/commit_ts.h
@@ -15,14 +15,10 @@
 #include "datatype/timestamp.h"
 #include "replication/origin.h"
 #include "storage/sync.h"
-#include "utils/guc.h"
 
 
 extern PGDLLIMPORT bool track_commit_timestamp;
 
-extern bool check_track_commit_timestamp(bool *newval, void **extra,
-										 GucSource source);
-
 extern void TransactionTreeSetCommitTsData(TransactionId xid, int nsubxids,
 										   TransactionId *subxids, TimestampTz timestamp,
 										   RepOriginId nodeid);

--------------21632BCF87EFC95614779452--