Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqL4z-0006aP-Ez for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Jun 2021 19:38:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lqL4y-0005uh-Dx for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Jun 2021 19:38:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqL4x-0005ts-JC for pgsql-hackers@lists.postgresql.org; Mon, 07 Jun 2021 19:38:32 +0000 Received: from wforward2-smtp.messagingengine.com ([64.147.123.31]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqL4t-0003K8-1F for pgsql-hackers@lists.postgresql.org; Mon, 07 Jun 2021 19:38:31 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailforward.west.internal (Postfix) with ESMTP id 9E36116C1; Mon, 7 Jun 2021 15:38:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 07 Jun 2021 15:38:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=mrcVEaTtMkq3QJs+HsME8ULJBq+3ibP0xoIg+6wcW Mg=; b=kAKL4XI7nIEak0sAv4Xsug36v9zPhnwOv5mx74exTcbbe0p9xVZVXVEnX DLeIWIYS1Jl7oHKSF8ohldrq8mb4eTdzFht+rPMzG/RNsZ6SyAdl1DL4f5ly++fT yjHU/81FDYCEh+3uoziReM5djL4oeKjbNRX7TOIdwDyp8F9Ua/6G46OyYHXnJHpv fVNywF+B31hbkhslq+XNbpS2GTUTAjWDT5ARM8kZuBhe/ARQdlPHH9ctY4ltUi/N dq0utjdHqstnNhxfhsCVrqepkH1Bqwy57att0HeCroacyLt3zdALuJ+jz8VL4Uz5 dEaG3MKbmnij36mXDRYs9REay6mUg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedtjedgudeflecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepuffvfhfhkffffgggjggtgfesth ejredttdefjeenucfhrhhomheprfgvthgvrhcugfhishgvnhhtrhgruhhtuceophgvthgv rhdrvghishgvnhhtrhgruhhtsegvnhhtvghrphhrihhsvggusgdrtghomheqnecuggftrf grthhtvghrnhepleevheehueeiudeiteeitdekueetleefteejffeiffdugedvffdvffdt iedvueeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epphgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Jun 2021 15:38:21 -0400 (EDT) Subject: Re: Tid scan improvements To: David Rowley , Edmund Horner Cc: PostgreSQL Developers References: <20210203211919.u7q3vq24g4pd63gv@alap3.anarazel.de> <20210216220522.3sn64ui3prwm43zh@alap3.anarazel.de> <05b070ee-b68c-56ca-be41-aa240ee62d81@enterprisedb.com> From: Peter Eisentraut Message-ID: Date: Mon, 7 Jun 2021 21:38:20 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 07.06.21 13:50, David Rowley wrote: > On Mon, 7 Jun 2021 at 23:46, Edmund Horner wrote: >> >> On Mon, 7 Jun 2021 at 22:11, Peter Eisentraut wrote: >>> >>> This patch didn't add _outTidRangePath() even though we have outNode() >>> coverage for most/all path nodes. Was this just forgotten? See >>> attached patch. >> >> >> Yes, it looks like an omission. Thanks for spotting it. Patch looks good to me. > > Yeah. That was forgotten. Patch also looks fine to me. Do you want > to push it, Peter? done