public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Heikki Linnakangas <[email protected]>
To: pgsql-hackers <[email protected]>
Subject: Re: some LLVM function checks missing in meson
Date: Wed, 17 Apr 2024 10:53:49 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On 13.04.24 10:25, Heikki Linnakangas wrote:
> There's also this in llvmjit.c:
> 
>>         if (llvm_opt3_orc)
>>         {
>> #if defined(HAVE_DECL_LLVMORCREGISTERPERF) && 
>> HAVE_DECL_LLVMORCREGISTERPERF
>>             if (jit_profiling_support)
>>                 LLVMOrcUnregisterPerf(llvm_opt3_orc);
>> #endif
>>             LLVMOrcDisposeInstance(llvm_opt3_orc);
>>             llvm_opt3_orc = NULL;
>>         }
>>
>>         if (llvm_opt0_orc)
>>         {
>> #if defined(HAVE_DECL_LLVMORCREGISTERPERF) && 
>> HAVE_DECL_LLVMORCREGISTERPERF
>>             if (jit_profiling_support)
>>                 LLVMOrcUnregisterPerf(llvm_opt0_orc);
>> #endif
>>             LLVMOrcDisposeInstance(llvm_opt0_orc);
>>             llvm_opt0_orc = NULL;
>>         }
>>     }
> 
> The autoconf test that set HAVE_DECL_LLVMORCREGISTERPERF was removed in 
> commit e9a9843e13. I believe that's a leftover that should also have 
> been removed.

Right, that was clearly forgotten.  I have removed the dead code.

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: some LLVM function checks missing in meson
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox