Subject: Re: pageinspect: Hash index support
To: Jesper Pedersen <jesper.pedersen@redhat.com>
References: <e2ac6c58-b93f-9dd9-f4e6-d6d30add7fdf@redhat.com>
 <0f99b6b0-0e54-0f6e-9502-f8cb6f194c17@redhat.com>
 <CAB7nPqSLVbe-wXCd77CMx6vHKfRd6thUwv7nzP54Lv9k4Q6hww@mail.gmail.com>
 <3493caf5-6d50-8915-7612-bd830972f513@redhat.com>
 <CAMkU=1weMVE+Re7NQyAtXT5g6E5Fziw9PVU9UDapb0AG5MH=YQ@mail.gmail.com>
 <CAE9k0Pk4dC9VrzV7Vm6em7JFzRMGfzx2=eYu0Yb_Psga-W47Ww@mail.gmail.com>
 <e1bda3f7-dc99-c610-4d48-58815f5b7515@redhat.com>
 <CAE9k0P=OQSEj0x9z91tvE9P1f-Ht7x7z8X+eDWQGTJNSFbn9yg@mail.gmail.com>
 <5d64a536-cc90-ce96-b68f-5b6bd3206476@redhat.com>
 <CAB7nPqTT3ZEm8QKsYYxfUnWL+P3p2mAbud7AFiZpK_JKx3eADA@mail.gmail.com>
 <d235dcd6-146a-1269-73a0-da9a55bfeddc@redhat.com>
 <80a00b5c-56d3-dffb-8dba-edf5d2167b12@2ndquadrant.com>
 <16d89e7e-cb1a-cb5d-e944-6f10c324a312@redhat.com>
 <c982b01c-06bc-485b-5dde-057ee244261a@2ndquadrant.com>
 <836487ee-8d4e-cd49-54ac-f4793ddba5ae@redhat.com>
 <8a751498-6ee9-b943-abf3-b5641851d7de@2ndquadrant.com>
 <62ee2eba-3a5b-06d3-e224-cfe00b395be7@redhat.com>
Cc: Michael Paquier <michael.paquier@gmail.com>,
 Ashutosh Sharma <ashu.coek88@gmail.com>, Jeff Janes <jeff.janes@gmail.com>,
 Alvaro Herrera <alvherre@2ndquadrant.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <f52f2117-627b-baa3-1e83-59394e881bf5@2ndquadrant.com>
Date: Thu, 29 Sep 2016 16:00:17 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <62ee2eba-3a5b-06d3-e224-cfe00b395be7@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

I think we should look into handling the different page types better.
The hash_page_stats function was copied from btree, which only has one
type.  It's not clear whether all the values apply to each page type.
At least they should be null if they don't apply.  BRIN has a separate
function for each page type, which might make more sense.  I suggest
taken the test suite that I posted and expanding the tests so that we
see output for each different page type.

Besides that, I would still like better data types for some of the
output columns, as previously discussed.  In addition to what I already
pointed out, the ctid column can be of type ctid instead of text.

Since the commit fest is drawing to a close, I'll set this patch as
returned with feedback.  Please continue working on it, since there is
clearly renewed interest in hash indexes, and we'll need this type of
functionality for that.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers