Message-ID: <f5442e4804d0e6d2d292569e98b34d36e852530c.camel@j-davis.com>
Subject: Re: Built-in CTYPE provider
From: Jeff Davis <pgsql@j-davis.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>, Daniel Verite
	 <daniel@manitou-mail.org>, Robert Haas <robertmhaas@gmail.com>, Jeremy
	Schneider <schneider@ardentperf.com>, pgsql-hackers@postgresql.org
Date: Mon, 18 Mar 2024 10:00:03 -0700
In-Reply-To: <3422201.1710711993@sss.pgh.pa.us>
References: <6f3e94c0-f174-4380-9b69-072f8a838881@manitou-mail.org>
	 <12e4f6a78403b33c303c20e44976f891d879be09.camel@j-davis.com>
	 <612987b5-38fa-44c6-8b78-c0be5a177a70@eisentraut.org>
	 <2692039df6b0cac20c5e488fa0209e8958c5fedb.camel@j-davis.com>
	 <27bb0e52-801d-4f73-a0a4-02cfdd4a9ada@eisentraut.org>
	 <4a69d067374d2f6bfb66f5bfb2ab9a020493d49f.camel@j-davis.com>
	 <3bc653b5d562ae9e2838b11cb696816c328a489a.camel@j-davis.com>
	 <163f4e2190cdf67f67016044e503c5004547e5a9.camel@j-davis.com>
	 <6bdb98e68b2b05aa71f7f934e227738eac84ecee.camel@j-davis.com>
	 <19b34a70-f5cf-4faf-88dc-917db44ed48d@eisentraut.org>
	 <846a7e1fa2024918b58ff7583523a2f3de9a11b4.camel@j-davis.com>
	 <3117d30aa911b408b90420f4f280fa0c3b5851be.camel@j-davis.com>
	 <4135cf11-206d-40ed-96c0-9363c1232379@eisentraut.org>
	 <7451f81ba0cb512222ab759de8ca1cffe44e9acb.camel@j-davis.com>
	 <3422201.1710711993@sss.pgh.pa.us>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/f5442e4804d0e6d2d292569e98b34d36e852530c.camel%40j-davis.com>
Precedence: bulk

On Sun, 2024-03-17 at 17:46 -0400, Tom Lane wrote:
> Jeff Davis <pgsql@j-davis.com> writes:
> > New series attached.
>=20
> Coverity thinks there's something wrong with builtin_validate_locale,
> and as far as I can tell it's right: the last ereport is unreachable,
> because required_encoding is never changed from its initial -1 value.
> It looks like there's a chunk of logic missing there, or else that
> the code could be simplified further.

Thank you, it was a bit of over-generalization in anticipation of
future patches.

It may be moot soon, but I committed a fix now.

Regards,
	Jeff Davis