Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0O6v-0008Qv-4Y for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Nov 2022 14:30:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p0O6u-0007JS-0X for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Nov 2022 14:30:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0O6t-0007JJ-Gu for pgsql-hackers@lists.postgresql.org; Wed, 30 Nov 2022 14:30:51 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p0O6q-0008WD-Fy for pgsql-hackers@postgresql.org; Wed, 30 Nov 2022 14:30:50 +0000 Received: from mail.postgrespro.ru (cyclops.postgrespro.ru [93.174.131.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id C0F5E21C2424; Wed, 30 Nov 2022 17:30:45 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1669818645; bh=drfXIUZ0BVA+wvE/6D1D4H4c3g81zBncfJ+Q04rizlU=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=j2bgBbAYIW2qbnshCDSG+XGqHxackrLe2WAtXMYDYFnJ2R+CNl+VtaGb5rrZazleH PQma5uKvFODdtXb1ayF6u5+1OR9rdalqhRyrTmrAQjMIZrZVVUWExVUt9ksPHIsaIT vRl9AXcDc43Drrobd3Rkzxm0ycRnx9MjYYgGP5A4= MIME-Version: 1.0 Date: Wed, 30 Nov 2022 17:30:45 +0300 From: Alexander Pyhalov To: "Fujii.Yuki@df.MitsubishiElectric.co.jp" Cc: Tomas Vondra , PostgreSQL-development , Andres Freund , Julien Rouhaud , Daniel Gustafsson , Ilya Gladyshev Subject: Re: Partial aggregates pushdown In-Reply-To: References: <05d98f67a4f44b31d90dfb977db4ad71@postgrespro.ru> <317f8de58ce9889e056f2944e200a44d@postgrespro.ru> <2ed9ad03bc17cfb86da900d541a270b0@postgrespro.ru> <20220114121653.mjzqelwgnzwqhkoa@jrouhaud> <0cc653ad90dbfc5ca0fd8bb1ca57e1a7@postgrespro.ru> <2ad047732a8b8a9aaaad06fef59fb283@postgrespro.ru> <925e2d3f11283d8b2707fc5d827fc3e9@postgrespro.ru> <20220322004914.opkwl3beedl4uhks@alap3.anarazel.de> <57db913f-02c6-66af-2928-513e2b1c65f7@enterprisedb.com> <8dc86e502fbd9d04da0dc6cdd4156f84@postgrespro.ru> <313df801f860f653ebb8c6422794a5b5@postgrespro.ru> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: a.pyhalov@postgrespro.ru Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Fujii.Yuki@df.MitsubishiElectric.co.jp писал 2022-11-30 13:01: >> 2) Do we really have to look at pg_proc in partial_agg_ok() and >> deparseAggref()? Perhaps, looking at aggtranstype is enough? > You are right. I fixed according to your comment. > partial_agg_ok() still looks at pg_proc. -- Best regards, Alexander Pyhalov, Postgres Professional