Subject: Re: Improve logging when using Huge Pages
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, noriyoshi.shinoda@hpe.com,
 rjuju123@gmail.com, pgsql-hackers@postgresql.org
References: 
 <CAOBaU_YGfFyruW4YX6++DifTtBt8bjatz0gMhaTRD=dqV3gdWg@mail.gmail.com>
 <7e5b9f6d-1db9-d1e2-3bd8-ef65f24b35be@oss.nttdata.com>
 <TU4PR8401MB1152CB4FEB99658BC6B35543EECF9@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
 <20210903.164934.1726669051525427478.horikyota.ntt@gmail.com>
 <1946f6b9-75a1-7aeb-7b06-6c018377e518@oss.nttdata.com>
 <2498302.1630679233@sss.pgh.pa.us>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <f5d8ab35-a44d-2f28-b86f-cd939c1000c4@oss.nttdata.com>
Date: Sat, 4 Sep 2021 01:35:30 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <2498302.1630679233@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/f5d8ab35-a44d-2f28-b86f-cd939c1000c4%40oss.nttdata.com>
Precedence: bulk


On 2021/09/03 23:27, Tom Lane wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>> IMO, if the level is promoted to LOG, the message should be updated
>> so that it follows the error message style guide. But I agree that simpler
>> message would be better in this case. So what about something like
>> the following?
> 
>> LOG: could not map anonymous shared memory (%zu bytes) with huge pages enabled
>> HINT: The server will map anonymous shared memory again with huge pages disabled.
> 
> That is not a hint.  Maybe it qualifies as errdetail, though.

Yes, agreed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION