MIME-Version: 1.0
Date: Mon, 15 May 2023 23:23:18 +0300
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org, Noah Misch <noah@leadboat.com>,
 exclusion@gmail.com
Subject: Re: Conflict between regression tests namespace & transactions due to
 recent changes
In-Reply-To: <2165312.1684167368@sss.pgh.pa.us>
References: <80d0201636665d82185942e7112257b4@postgrespro.ru>
 <2165312.1684167368@sss.pgh.pa.us>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <f62cd65e1b179783521f424a42ef3b27@postgrespro.ru>
Organization: Postgres Professional
Content-Type: multipart/mixed;
 boundary="=_92254c672d14cc11e79b5c85859f7b5e"
Archived-At: 
 <https://www.postgresql.org/message-id/f62cd65e1b179783521f424a42ef3b27%40postgrespro.ru>
Precedence: bulk

--=_92254c672d14cc11e79b5c85859f7b5e
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

On 2023-05-15 19:16, Tom Lane wrote:
> Marina Polyakova <m.polyakova@postgrespro.ru> writes:
>> IIUC the conflict was caused by
> 
>> +SET search_path to public, test_ns_schema_1;
>> +CREATE SCHEMA test_ns_schema_2
>> +       CREATE VIEW abc_view AS SELECT a FROM abc;
> 
>> because the parallel regression test transactions had already created
>> the table abc and was trying to drop it.
> 
> Hmm.  I'd actually fix the blame on transactions.sql here.  Creating
> a table named as generically as "abc" is horribly bad practice in
> a set of concurrent tests.  namespace.sql is arguably okay, since
> it's creating that table name in a private schema.
> 
> I'd be inclined to fix this by doing s/abc/something-else/g in
> transactions.sql.
> 
> 			regards, tom lane

Maybe use a separate schema for all new objects in the transaction 
test?.. See diff_set_tx_schema.patch.

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--=_92254c672d14cc11e79b5c85859f7b5e
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=diff_set_tx_schema.patch
Content-Disposition: attachment;
 filename=diff_set_tx_schema.patch;
 size=1129

ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvdHJhbnNhY3Rpb25zLm91dCBi
L3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvdHJhbnNhY3Rpb25zLm91dAppbmRleCAyYjJjZmY3
ZDkxMjBhMTM5NTMyZDFhNmEyZjJiYzc5ZTQ2M2JjNGZhLi42YTM3NThiYWZiNTQzMjdmYmUzNDFk
ZmQ4OTQ1N2U1M2ZmY2U0N2RkIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVk
L3RyYW5zYWN0aW9ucy5vdXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC90cmFuc2Fj
dGlvbnMub3V0CkBAIC0xLDYgKzEsMTAgQEAKIC0tCiAtLSBUUkFOU0FDVElPTlMKIC0tCistLSBV
c2UgeW91ciBzY2hlbWEgdG8gYXZvaWQgY29uZmxpY3RzIHdpdGggb2JqZWN0cyB3aXRoIHRoZSBz
YW1lIG5hbWVzIGluCistLSBwYXJhbGxlbCB0ZXN0cy4KK0NSRUFURSBTQ0hFTUEgdGVzdF90eF9z
Y2hlbWE7CitTRVQgc2VhcmNoX3BhdGggVE8gdGVzdF90eF9zY2hlbWEscHVibGljOwogQkVHSU47
CiBDUkVBVEUgVEFCTEUgeGFjdHRlc3QgKGEgc21hbGxpbnQsIGIgcmVhbCk7CiBJTlNFUlQgSU5U
TyB4YWN0dGVzdCBWQUxVRVMKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3RyYW5z
YWN0aW9ucy5zcWwgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC90cmFuc2FjdGlvbnMuc3FsCmluZGV4
IDdlZTVmNmFhYTU1YTY4NmY1NDg0NjY0YzNmYWUyMjRjMDhiZGU0MmEuLjBlNmQ2NDUzZWRhYTc3
NjQyNTUyNGQ0M2FiZjVhZTNjZmNhM2FjNDUgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3JlZ3Jlc3Mv
c3FsL3RyYW5zYWN0aW9ucy5zcWwKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9zcWwvdHJhbnNhY3Rp
b25zLnNxbApAQCAtMiw2ICsyLDExIEBACiAtLSBUUkFOU0FDVElPTlMKIC0tCiAKKy0tIFVzZSB5
b3VyIHNjaGVtYSB0byBhdm9pZCBjb25mbGljdHMgd2l0aCBvYmplY3RzIHdpdGggdGhlIHNhbWUg
bmFtZXMgaW4KKy0tIHBhcmFsbGVsIHRlc3RzLgorQ1JFQVRFIFNDSEVNQSB0ZXN0X3R4X3NjaGVt
YTsKK1NFVCBzZWFyY2hfcGF0aCBUTyB0ZXN0X3R4X3NjaGVtYSxwdWJsaWM7CisKIEJFR0lOOwog
CiBDUkVBVEUgVEFCTEUgeGFjdHRlc3QgKGEgc21hbGxpbnQsIGIgcmVhbCk7Cg==
--=_92254c672d14cc11e79b5c85859f7b5e--