Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEQZs-0008JO-RQ for pgsql-hackers@arkaria.postgresql.org; Mon, 31 Jan 2022 06:54:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nEQZq-0008Il-2J for pgsql-hackers@arkaria.postgresql.org; Mon, 31 Jan 2022 06:54:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEQZo-0008Ic-QY for pgsql-hackers@lists.postgresql.org; Mon, 31 Jan 2022 06:54:13 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEQZk-00029y-4I for pgsql-hackers@postgresql.org; Mon, 31 Jan 2022 06:54:12 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id DC7EB5C00A6; Mon, 31 Jan 2022 01:54:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 31 Jan 2022 01:54:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=DJbkxygJDJtbpYziervxD4QP91C4ewaOm/ob2L+lR vk=; b=DvOeGs/xEqAcjlIxnD+mTpPI16iSoRoiqyze88el7vVB0lw39T9+h+yLX mJGZ3jKStxXgC019Q6iO8u+TXfqurRXOeRppGeekKPxD+bY6Dc3NjZ1N8502ogza eMO+AuWvI23g8KE/gg+1IjwjXfkeC2kr6D+eQ0plshYUvDbuzU7YkeJghx5m0Jio 8HHoD2YXpkRja8aZwLfuST0bwxcLmKEC6EZQdmKx8ZHcn7hCp0ssYamY+19JEi/4 rlqgIQY5Zwr85rFZzbQg6j+a3x6vWxdbhQSO1cF9V2sEXc7gbNKALKeZ5S4tTINT ASjj1PuCNfaEBeATDUVnwv668rvqg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgedtgddutddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthekredttdefjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvg hrphhrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnheplefgteefiedtleelgeeg jeevhfeuteefvddtjeehveeuieefgedvhfeuleduteeunecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhht segvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 31 Jan 2022 01:54:03 -0500 (EST) Message-ID: Date: Mon, 31 Jan 2022 07:54:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: Add header support to text format and matching feature Content-Language: en-US To: =?UTF-8?Q?R=c3=a9mi_Lapeyre?= Cc: Zhihong Yu , David Steele , Michael Paquier , vignesh C , PostgreSQL-development , Daniel Verite References: <018819f7-6cbe-4f20-903f-de1b9e434119@manitou-mail.org> <9B3E4BEB-F6E2-4D4D-AFB8-58FB3957EB35@lenstra.fr> <29be62a4-e931-b745-3e24-7aa111963447@pgmasters.net> <8A231E8D-4491-4DC2-AF72-EBEAEF0F0967@lenstra.fr> <683DD77E-38B3-4BC2-810E-4122C7A5A053@lenstra.fr> <8964EEB0-7AE1-4549-BA4C-119EF8CD266C@lenstra.fr> <94FDDB44-A608-4C75-A733-9F8FC5180D6B@lenstra.fr> <4816b2df-646f-dc19-e5cc-4bfbd04c0e43@enterprisedb.com> <07891B9D-2140-4C06-AF96-C14F1E1B0E8E@lenstra.fr> From: Peter Eisentraut In-Reply-To: <07891B9D-2140-4C06-AF96-C14F1E1B0E8E@lenstra.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 30.01.22 23:56, Rémi Lapeyre wrote: >> I notice in the 0002 patch that there is no test case for the error "wrong header for column \"%s\": got \"%s\"", which I think is really the core functionality of this patch. So please add that. >> > > I added a test for it in this new version of the patch. The file_fdw.sql tests contain this +CREATE FOREIGN TABLE header_doesnt_match (a int, foo text) SERVER file_server +OPTIONS (format 'csv', filename :'filename', delimiter ',', header 'match'); -- ERROR but no actual error is generated. Please review the additions on the file_fdw tests to see that they make sense.