Feedback-ID: i131946ab:Fastmail
Content-Type: multipart/mixed; boundary="------------GxQiBtc5T0mTZRKw4UBIeWus"
Message-ID: <f64365b1-d5f9-ef83-41fe-404810f10e5a@enterprisedb.com>
Date: Mon, 31 Oct 2022 10:02:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: Simplifying our Trap/Assert infrastructure
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-hackers@lists.postgresql.org
References: <3928703.1665345117@sss.pgh.pa.us>
 <20221009210148.GA900071@nathanxps13> <20221012183620.GA1447761@nathanxps13>
 <fe8a3770-1256-cf96-f3fa-db526fd09568@enterprisedb.com>
 <Y1oyCXhg/6Odn6L/@paquier.xyz>
 <572ed6f8-a137-0a52-a35e-a48df95af6ed@enterprisedb.com>
 <Y18RCGE+Lyl07HyN@paquier.xyz>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <Y18RCGE+Lyl07HyN@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/f64365b1-d5f9-ef83-41fe-404810f10e5a%40enterprisedb.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------GxQiBtc5T0mTZRKw4UBIeWus
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 31.10.22 01:04, Michael Paquier wrote:
> On Fri, Oct 28, 2022 at 09:36:23AM +0200, Peter Eisentraut wrote:
>> Would there be a use for that?  It's currently only used in the atomics
>> code.
> 
> Yep, but they would not trigger when using atomics in the frontend
> code.  We don't have any use for that in core on HEAD, still that
> could be useful for some external frontend code?  Please see the
> attached.

I don't think we need separate definitions for frontend and backend, 
since the contained Assert() will take care of the difference.  So the 
attached would be simpler.

--------------GxQiBtc5T0mTZRKw4UBIeWus
Content-Type: text/plain; charset=UTF-8;
 name="0001-Make-AssertPointerAlignment-available-to-frontend-co.patch"
Content-Disposition: attachment;
 filename*0="0001-Make-AssertPointerAlignment-available-to-frontend-co.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSBiMTFkZTAzMTg1ZTZlMmYyZjJkMGIyYjNhMThhZGIwMTlhYWRlNjEwIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogTW9uLCAzMSBPY3QgMjAyMiAxMDowMDo0NCArMDEwMApTdWJqZWN0
OiBbUEFUQ0hdIE1ha2UgQXNzZXJ0UG9pbnRlckFsaWdubWVudCBhdmFpbGFibGUgdG8gZnJv
bnRlbmQgY29kZQoKLS0tCiBzcmMvaW5jbHVkZS9jLmggfCA2ICsrLS0tLQogMSBmaWxlIGNo
YW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9z
cmMvaW5jbHVkZS9jLmggYi9zcmMvaW5jbHVkZS9jLmgKaW5kZXggZDcwZWQ4NGFjNThlLi45
OGNkZDI4NWRkOTggMTAwNjQ0Ci0tLSBhL3NyYy9pbmNsdWRlL2MuaAorKysgYi9zcmMvaW5j
bHVkZS9jLmgKQEAgLTc5MywxNCArNzkzLDEyIEBAIHR5cGVkZWYgTmFtZURhdGEgKk5hbWU7
CiAKICNkZWZpbmUgQXNzZXJ0KGNvbmRpdGlvbikJKCh2b2lkKXRydWUpCiAjZGVmaW5lIEFz
c2VydE1hY3JvKGNvbmRpdGlvbikJKCh2b2lkKXRydWUpCi0jZGVmaW5lIEFzc2VydFBvaW50
ZXJBbGlnbm1lbnQocHRyLCBibmRyKQkoKHZvaWQpdHJ1ZSkKIAogI2VsaWYgZGVmaW5lZChG
Uk9OVEVORCkKIAogI2luY2x1ZGUgPGFzc2VydC5oPgogI2RlZmluZSBBc3NlcnQocCkgYXNz
ZXJ0KHApCiAjZGVmaW5lIEFzc2VydE1hY3JvKHApCSgodm9pZCkgYXNzZXJ0KHApKQotI2Rl
ZmluZSBBc3NlcnRQb2ludGVyQWxpZ25tZW50KHB0ciwgYm5kcikJKCh2b2lkKXRydWUpCiAK
ICNlbHNlCQkJCQkJCS8qIFVTRV9BU1NFUlRfQ0hFQ0tJTkcgJiYgIUZST05URU5EICovCiAK
QEAgLTgyNCwxNCArODIyLDE0IEBAIHR5cGVkZWYgTmFtZURhdGEgKk5hbWU7CiAJKCh2b2lk
KSAoKGNvbmRpdGlvbikgfHwgXAogCQkJIChFeGNlcHRpb25hbENvbmRpdGlvbigjY29uZGl0
aW9uLCBfX0ZJTEVfXywgX19MSU5FX18pLCAwKSkpCiAKKyNlbmRpZgkJCQkJCQkvKiBVU0Vf
QVNTRVJUX0NIRUNLSU5HICYmICFGUk9OVEVORCAqLworCiAvKgogICogQ2hlY2sgdGhhdCBg
cHRyJyBpcyBgYm5kcicgYWxpZ25lZC4KICAqLwogI2RlZmluZSBBc3NlcnRQb2ludGVyQWxp
Z25tZW50KHB0ciwgYm5kcikgXAogCUFzc2VydChUWVBFQUxJR04oYm5kciwgKHVpbnRwdHJf
dCkocHRyKSkgPT0gKHVpbnRwdHJfdCkocHRyKSkKIAotI2VuZGlmCQkJCQkJCS8qIFVTRV9B
U1NFUlRfQ0hFQ0tJTkcgJiYgIUZST05URU5EICovCi0KIC8qCiAgKiBFeGNlcHRpb25hbENv
bmRpdGlvbiBpcyBjb21waWxlZCBpbnRvIHRoZSBiYWNrZW5kIHdoZXRoZXIgb3Igbm90CiAg
KiBVU0VfQVNTRVJUX0NIRUNLSU5HIGlzIGRlZmluZWQsIHNvIGFzIHRvIHN1cHBvcnQgdXNl
IG9mIGV4dGVuc2lvbnMKLS0gCjIuMzcuMwoK

--------------GxQiBtc5T0mTZRKw4UBIeWus--