Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dunCd-0000TU-BE for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Sep 2017 22:10:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dunCc-0000lj-Se for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Sep 2017 22:10:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dunB3-0006MT-7B for pgsql-hackers@postgresql.org; Wed, 20 Sep 2017 22:09:05 +0000 Received: from mail-yw0-x233.google.com ([2607:f8b0:4002:c05::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dunAz-0007Hm-71 for pgsql-hackers@postgresql.org; Wed, 20 Sep 2017 22:09:04 +0000 Received: by mail-yw0-x233.google.com with SMTP id w22so2875158ywa.13 for ; Wed, 20 Sep 2017 15:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=hcFKqtgLQ6ozuJ1Dud6RPZDKXMae6QMaDUkOIbkBQCk=; b=iFmfywnJOZvEDypHg7eUqodH/Tp94hfI+lRYKthe/yXO0ZJS2X5QWfGzRlJAG/lgF+ BFMpCgrYfyzmto0kVTwf8wk9ZXPpR2pc/OE195qTJk9BcDWFdVl29fdTMLp95gNH4nn6 +y30+8Z5+uDvDmZwNuVyAqfSeDDpWb9x7ekBR/IIY/L0/IrnXF36W4a+s0R+ZUGUl6ta TX329ffiVDvPglQO5XdA84CAPl6JIo8tO+7f1Sl/zQmik4rGsRhjMlp5i91GhRgE8cKX LRaPDDfaRNd28fNymSUdPucV3IeMIO+1WEWwS7FwF+kD5L+Qz5KHTi+tdt75zjne0rhP fGyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=hcFKqtgLQ6ozuJ1Dud6RPZDKXMae6QMaDUkOIbkBQCk=; b=gmfGJ4ej9OfPzGPnaWmjssotZazdlYEvvW+ShLOR/cOVcyfpm9CctKaxayy1e05W+Z QpfpKgAQBRQrh+0OE/j8uBppQ0kiOCauUng1PyIMECEWofN1lFqPeA7lIKKXsK92nIYi CdKZF8iNrEl8qXnrD8dGEhKGH/STlZGrhRJ9F3i7FgEU4Z/zFvWhHo1d7CDNnMG25mVA CtLqwZYBkDkBKoOR87CfHOsVdmfSAy5YpAOVWJt0g/9jyw6V4hM84Vj/DYbCvXPYwwix KwRyxRDaQ4KcjUVEou2Vzi8rVfTx8PbqicLIAC38WDrk/OBw5gbBJ0H0MBOx32ZNFPUS VnGw== X-Gm-Message-State: AHPjjUjr/NjTqapnZp2qZEBWYZ0xUUEKBQJHyEpDtQbkbRu+szOvRlNh VsHaUo4bL63rgDGC6HsV2uaZY0lxN+/xVPnUZo6gtjT7GoB4YxYRh/Aa2fEZflEVdeR921vie1G 6+rU01zKV3Z7RkHwEmDCP2LFAqa7TUKR4B++AKr41n3nIC6gAtO5nLgBPmBUEV6kr6cXO+OsSqU 3ZW/YN0sELtpoF X-Google-Smtp-Source: AOwi7QDbYUGUBPA7kgsPH2bcGnKf0xTRIhczn2sAAmgFcPBL4RxiGEOU71EmDAH4TF1Hqupr2SXK4g== X-Received: by 10.129.182.94 with SMTP id h30mr148941ywk.278.1505945339165; Wed, 20 Sep 2017 15:08:59 -0700 (PDT) Received: from [192.168.10.146] ([98.122.175.38]) by smtp.gmail.com with ESMTPSA id h186sm1140062ywh.52.2017.09.20.15.08.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Sep 2017 15:08:58 -0700 (PDT) From: Andrew Dunstan X-Google-Original-From: Andrew Dunstan To: PostgreSQL-development Subject: Windows warnings from VS 2017 Message-ID: Date: Wed, 20 Sep 2017 18:08:58 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-MW List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org I'm working through testing the changes to allow building with Visual Studio 2017. I've noticed that there are some warnings that we don't see in earlier compilers. First, it warns about a couple of unused variables at lines 4553 and 4673 of src/backend/optimizer/path/costsize.c. I think we can do a little rearrangement to keep it happy there. It's also warning that it will copy 16 bytes to a 13 byte structure at lines 518, 1293 and 1294 of src/backend/commands/dbcommands.c. I haven't seen any ill effects of this so far, but it seems to indicate that something is possibly amiss on this compiler with the MemSet macros. The regression tests are currently failing on my test platform (Windows Server 2016) because it says it can't change permissions on the testtablespace directory. I have no idea what's going on there, still investigating. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers