Subject: Re: Removing support for COPY FROM STDIN in protocol version 2
To: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <20210203160958.GA2341@alvherre.pgsql>
 <3921698.1612369777@sss.pgh.pa.us>
From: Heikki Linnakangas <hlinnaka@iki.fi>
Message-ID: <f69a7e6b-66f6-cbab-a414-ecc5c2127208@iki.fi>
Date: Wed, 3 Feb 2021 18:47:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <3921698.1612369777@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/02/2021 18:29, Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
>> On 2021-Feb-03, Tom Lane wrote:
>>> I have a vague recollection that JDBC users still like to use
>>> protocol 2 for some reason --- is that out of date?
> 
>> [ yes, since 2016 ]
> 
> Then let's kill it dead, server and libpq both.

Ok, works for me. I'll prepare a larger patch to do that.

Since we're on a removal-spree, it'd also be nice to get rid of the 
"fast-path" function call interface, PQfn(). However, libpq is using it 
internally in the lo_*() functions, so if we remove it from the server, 
lo_*() will stop working with old libpq versions. It would be good to 
change those functions now to use PQexecParams() instead, so that we 
could remove the fast-path server support in the future.

- Heikki