Subject: Re: Improve handling of parameter differences in physical replication
To: Sergei Kornilov <sk@zsrv.org>,
 Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
References: 
 <CA+fd4k4G8pFDha522kPAh_H2d3be6ejc56H932h_xHXPA+mV5Q@mail.gmail.com>
 <20200310.175755.1250389993502025042.horikyota.ntt@gmail.com>
 <aa078efe-2d25-fdab-5bdb-158edab5d849@2ndquadrant.com>
 <20200311.110637.1319131984113864409.horikyota.ntt@gmail.com>
 <2134a29f-e934-4585-e81f-ab416e1923be@2ndquadrant.com>
 <CA+fd4k4G3pAY+KPDzNRCGu=FZQT81KhXT-8EcjYGpc6cpmiT9w@mail.gmail.com>
 <2808491585335240@iva3-67f911cb3a01.qloud-c.yandex.net>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 =?UTF-8?Q?=c3=81lvaro_Herrera?= <alvherre@2ndquadrant.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <f71030f1-cd0a-5e7c-5d09-cbebc6603bf5@2ndquadrant.com>
Date: Mon, 30 Mar 2020 10:09:48 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <2808491585335240@iva3-67f911cb3a01.qloud-c.yandex.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-03-27 20:15, Sergei Kornilov wrote:
>> I think we can set wait event WAIT_EVENT_RECOVERY_PAUSE here.
> 
> +1, since we added this in recoveryPausesHere.

committed with that addition

> PS: do we need to add a prototype for the RecoveryRequiredIntParameter function in top of xlog.c?

There is no consistent style, I think, but I usually only add prototypes 
for static functions if they are required because of the ordering in the 
file.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services