Message-ID: <f73f4287-aadd-4914-8052-76167fb4934c@iki.fi>
Date: Mon, 28 Oct 2024 16:32:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: define pg_structiszero(addr, s, r)
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers@lists.postgresql.org
References: <ZupUDDyf1hHI4ibn@ip-10-97-1-34.eu-west-3.compute.internal>
 <3023d29e-0fe7-4bec-9028-7f3c0102e437@eisentraut.org>
 <ZusioyiXTyKpOP/2@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <ZusioyiXTyKpOP/2@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/f73f4287-aadd-4914-8052-76167fb4934c%40iki.fi>
Precedence: bulk

On 18/09/2024 21:57, Bertrand Drouvot wrote:
> On Wed, Sep 18, 2024 at 10:03:21AM +0200, Peter Eisentraut wrote:
>> On 18.09.24 06:16, Bertrand Drouvot wrote:
>>> +#define pg_structiszero(addr, s, r)									\
>>> +	do {															\
>>> +		/* We assume this initializes to zeroes */					\
>>> +		static const s all_zeroes;									\
>>> +		r = (memcmp(addr, &all_zeroes, sizeof(all_zeroes)) == 0);	\
>>> +	} while (0)

Not new with this patch, but do we guarantee padding bytes to be zeros?

How about this instead:

static inline bool
pg_is_all_zeros(const char *p, size_t len)
{
   for (size_t i = 0; i < len; i++)
   {
     if (p[i] != 0)
         return false;
   }
   return true;
}

Is there's a de facto standard name for that function? I was surprised 
that I couldn't find one with a quick google search. That seems like the 
kind of small utility function that every C program needs.

How performance sensitive is this? If it's not, then the above seems 
like the most straightforward way to do this, which is good. If it is 
performance sensitive, it's still good, because the compiler can 
optimize that well: https://godbolt.org/z/x9hPWjheq.

-- 
Heikki Linnakangas
Neon (https://neon.tech)