Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3FHq-0002z3-Vz for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Mar 2019 07:23:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h3FHp-0001X1-O1 for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Mar 2019 07:23:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3FHp-0001Ws-G6 for pgsql-hackers@lists.postgresql.org; Mon, 11 Mar 2019 07:23:49 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3FHl-0004kv-VJ for pgsql-hackers@postgresql.org; Mon, 11 Mar 2019 07:23:48 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id D8C903762 for ; Mon, 11 Mar 2019 03:23:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 11 Mar 2019 03:23:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=7ODxxFrqzQsZMZ4/ZFswo+mukG6R1 qlRQv86mZkeiPg=; b=0X9+p7gFMxJO1nJVuMBilD+RHZZSqWu7sQsqylDN6dWzG 2kB2xzm8CMTI0j2nvhy1A3lxgXz4ta1/bisGrEnlReFWLsOR90T7sGWNois489ky 96EBuIcPxIq/vETj0G9p6Ybecg+9cGzL2vJyosWWxdaao78CdIj5NHqVoyE6fPyc ugvrjARhFg+kQfkn2sy03bDbGsfHKlOKGSvsmWN+6lz4krUqu2y8hXUv1EnkHwFx W1onIAgdE/1YBVqCCtYt4vjeQIgpymxO/7IFjk3G7vLoR4/FF93cMPDVMP1DdXrK pMta8tKe3Y9ENV927WZaG7NhH9R9SBaIH8CoMxjmg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrgeehgddutdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefvhffuohfkffgfgggtsehmtderre dtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgv ihhsvghnthhrrghuthesvdhnughquhgrughrrghnthdrtghomheqnecuffhomhgrihhnpe dvnhguqhhurggurhgrnhhtrdgtohhmnecukfhppeelfedrvdegfedrudekkedruddvvden ucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhhtsedvnh guqhhurggurhgrnhhtrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from april.pezone.net (p5df3bc7a.dip0.t-ipconnect.de [93.243.188.122]) by mail.messagingengine.com (Postfix) with ESMTPA id 5FDCC10331 for ; Mon, 11 Mar 2019 03:23:41 -0400 (EDT) To: pgsql-hackers From: Peter Eisentraut Subject: Fix volatile vs. pointer confusion Openpgp: preference=signencrypt Autocrypt: addr=peter.eisentraut@2ndquadrant.com; prefer-encrypt=mutual; keydata= xsFNBFUUt6kBEADZd9NNTBJbHmAXXJgPGOdd6Q73l80oifIVgn2tRxP9dYkCfTlo/yLqbKTl JNqTcyM6XrJDnB2sMEUGYCewYZXl+9C4bBJWyNqcEI1ae9u71vEq/fknFLArJ+2wN+f7QuRx Q8d94ZJAiJQ5g3fNk2HVeedCQCKP5dCzU+ZLt2dbsx1PDZLjTO9gf+JswWuGFb5wY5PZVM5V hq66Xk7ZJzHuARacza2RT7J2fkMmQBY+kr7L98Perb0GhafnlhXB0PvUB+N3xpmggMfwuhTu BngS/G/r3GvemxJuFxouw8xsMqrsfdksJXA2gLXYtwRCssdPV3PO0rlD9twqDo8URfIJ5fb6 1g/MV8aTOKjg3Q8MpJPtkwJqN4o3PvbwYdedeFnOVkkYAJdu/aX1v1BeCBDu7Hy3sF52scD3 pQbyQSl9vUDpTLarASAxNbAV0NRJE8dp4vfW6AH1ccryGiFqw/czPK/iN0+MT8wsjAW6WW4w hvjm5UPA1KTwi3ZT8eT5uycuH7QpuNk7LnGGXQ6KaRALFywzkr0A0V0AvFNa+l4wstMaXaB6 dmMXyF0/hfryqyOeu1gAdq4q0/PNC2dPgb/6uoh4eMjN6A5GXcprilhz5DulmsilY21hfSoU S64ODed96pKhprsOxjZiDRsN1QM5MwB+uwVWUNfsX7fIxE0BrwARAQABzSdQZXRlciBFaXNl bnRyYXV0IDxwZXRlckBlaXNlbnRyYXV0Lm9yZz7CwXoEEwEIACQCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AFAlUUuKQCGQEACgkQoZ8SQ+xBJp8llw//RbGoXnF72FZTlOFsnNyxnWbF vViPCfdAlZl1GGK9OYCvV1dp/956HuhB0wpaGQHiBmQfOPJf/jLOPjXFYm2iEChEycrBChuE j4TSYemMp5BSPILYk9Uwd16kVD/+U6fQfK6H5pOhfBvbM6asMnmpY2wQuvktxHvaGlytFw84 EzFWNZtAZfxkw28w3AhIQkKe9hJanfyDL750RcbyEr8AAHty5IErrvS7tM5vQwIeh5BF26ND CyKPRdZgOgMpcwFfROKBDpAt052CgWIpNdhBdfIKlkCs4/ILxmC3rT/Mb/qZiHcoMMwEu6k+ T7vRAFZZAk62Yrr/U8/vUGKlzRZQoo86fyojCfI0ibCIc0z8rwCVY9P40G9wD9BTCZS/z8Vh jjpBlNnIKw2hM6hbxavKndCJjFFJD08rXrTyrLF/of18xD37vNdYooP9VATB5QjOWFRrscSZ 4a89e+to3m7YVnd4xdXwGp47dYusoax84C8tg1gZrH38ol9dPmnKX6GZrXeS7tH9k8VeUpJ8 HQbRThQRWAT936QpYbLConBmOtmbLmjQOGtiXPo1oK57X/7U/WBja5vWmm2q+Yxtt+3uHGVg DdDU4CJpXo4lX0v2n3QV5EBSW9hjdF3bNfl6GFBb1pPEhqNcMDUc7zkx/2uENdAdk/BnqMgH umip7b0pVfvOwU0EVRS3qQEQAJf6p0P7D+hMYUgCPkvgrcz6OJYsAYdUMUmokfqmkKwK0oJM ew8TNGM53ocKAgQGma5f10rwbZNPlpVPNRX5hwUmwVlcwSut0oE+JfUBH7mpysWvpF05RKIy q9RCoJZrAbXS7Tig56A1QD8IcM00rERZMcCOlI1+q9m4u9AOI+0LyGGSH+VvoyDHD/Jew4R2 TmPEF8Pu7lYiNYK88Q6u0kBkc+Tz3BNlyc6fi3HxnFfp0b75HLXPSTu2SwA/0Q31wHZXwrEU BR9KgSn/qbgy8ydPc97i82fhiFE3cbGexfPrQSMYmDGi+dcQ0s+AMQwC3XyMC0JkHpYUuFkR QdlIvaIhgFUUN2Vr4xF2ADaNTNFc4DYaiPHFAgHZw+3pZWqS4uIiWgJynrEaHw4F3QWU8/JB iyEWDhNq4WBrRA0u914TCCAoFOOKMnRdl8eJrRQKM/5/lXbHFjjlI/LDKhLRFsuQsnJJ3331 RjCzpHPZG5/p5KR1RHiAXa0p/DW5lXyq21hS3kjDlleoHqOxCN/cy0Jgz7qLDq1vZoCl67Sy RAH60c2Xu4may9SVltmot0OzWVHdrfS+85FQGp9580DaeLio7YMFKy2bfEvwQJ/c9xD2QPB+ oSb3V8ueSznXBG5+dyfOsZFRPxceA0wA2rSWZSjxLdKxvyGTj9vsCjaDu13rABEBAAHCwV8E GAEIAAkFAlUUt6kCGwwACgkQoZ8SQ+xBJp+HJhAAxmSTsC5y7p9Zu+nnLpucv/h88oEx985e qWeXzQiwM3pfRZS+PdTH9TyzHK0KOgKoAiubk0vt+BrT91D9d0G5kVQaTctAErGBoMkTaZJT XVEcNphiPzysdSqvprjojMp1y7rG8AP+Xd6m0rE1LRnkRRm8HyI8vdXsuLQPITGWXDLMjaNq AOV3BUnzkgtjMuIYw7SCr+12ZOb5dEKvaG4kjC4kaJ/TLbuBhVANcXkC90yp0AOZLs/cB1Dj OAXno/RUUruJ3r27a+pFv768UAi9QWcdw58yPxreMNMLqAgsS9oTHwHfGNWcB2dJ4UW+GMLJ hTf9TjQ2f+N/sIx5XMQ9pYw6CAJMK29qPx6/ZayrPxf22EXf0D3zTwIEZgwfSkynFVwV25L7 awQq60fifdMYheSxq7GbhpsixmcD+e161cCmLIt75YDt5bQ0B1yf7EmxG8n7pGZAOM6LoNsU fkSldba5XVwh8LuN5mK0nQBELGW6Os4TDq4REggLpfcvFC215zpuo0iCGnmE/Bns4nowqUSP u4tkWL+nxW4qgv8wo8HJ52jd79EJ8iqfIBoidBfy9AIUiEUApGQzWPu6yWcI8fY0rN5D+tc+ Yw1Zt6Mm+huYJpgCRsTcfzEcahnBn521CWcWvhW1ff3KFileFMtNmnBBhMncmRKHphtTKEpN 3jI= Organization: 2ndQuadrant Message-ID: Date: Mon, 11 Mar 2019 08:23:39 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------776672112DE1B1A3AB88CC87" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------776672112DE1B1A3AB88CC87 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Variables used after a longjmp() need to be declared volatile. In case of a pointer, it's the pointer itself that needs to be declared volatile, not the pointed-to value. So we need PyObject *volatile items; instead of volatile PyObject *items; /* wrong */ Attached patch fixes a couple of cases of that. Most instances were already correct. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --------------776672112DE1B1A3AB88CC87 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="0001-Fix-volatile-vs.-pointer-confusion.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-volatile-vs.-pointer-confusion.patch" RnJvbSAxYmI2YWNmNjNjZjc5NmQwNjU5MjgzYzdlYTUyMjAzODVmN2RlMTgxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogTW9uLCAxMSBNYXIgMjAxOSAwODoxODo1NSArMDEwMApTdWJqZWN0 OiBbUEFUQ0hdIEZpeCB2b2xhdGlsZSB2cy4gcG9pbnRlciBjb25mdXNpb24KClZhcmlhYmxl cyB1c2VkIGFmdGVyIGEgbG9uZ2ptcCgpIG5lZWQgdG8gYmUgZGVjbGFyZWQgdm9sYXRpbGUu ICBJbgpjYXNlIG9mIGEgcG9pbnRlciwgaXQncyB0aGUgcG9pbnRlciBpdHNlbGYgdGhhdCBu ZWVkcyB0byBiZSBkZWNsYXJlZAp2b2xhdGlsZSwgbm90IHRoZSBwb2ludGVkLXRvIHZhbHVl LiAgU28gd2UgbmVlZAoKICAgIFB5T2JqZWN0ICp2b2xhdGlsZSBpdGVtczsKCmluc3RlYWQg b2YKCiAgICB2b2xhdGlsZSBQeU9iamVjdCAqaXRlbXM7ICAvKiB3cm9uZyAqLwotLS0KIGNv bnRyaWIvaHN0b3JlX3BscHl0aG9uL2hzdG9yZV9wbHB5dGhvbi5jIHwgOSArKysrLS0tLS0K IGNvbnRyaWIvanNvbmJfcGxweXRob24vanNvbmJfcGxweXRob24uYyAgIHwgOSArKystLS0t LS0KIDIgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9jb250cmliL2hzdG9yZV9wbHB5dGhvbi9oc3RvcmVfcGxweXRob24u YyBiL2NvbnRyaWIvaHN0b3JlX3BscHl0aG9uL2hzdG9yZV9wbHB5dGhvbi5jCmluZGV4IDJm MjQwOTBmZjMuLjkzYzM5ZDI5NGQgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIvaHN0b3JlX3BscHl0 aG9uL2hzdG9yZV9wbHB5dGhvbi5jCisrKyBiL2NvbnRyaWIvaHN0b3JlX3BscHl0aG9uL2hz dG9yZV9wbHB5dGhvbi5jCkBAIC0xMjgsNyArMTI4LDcgQEAgRGF0dW0KIHBscHl0aG9uX3Rv X2hzdG9yZShQR19GVU5DVElPTl9BUkdTKQogewogCVB5T2JqZWN0ICAgKmRpY3Q7Ci0Jdm9s YXRpbGUgUHlPYmplY3QgKml0ZW1zX3YgPSBOVUxMOworCVB5T2JqZWN0ICp2b2xhdGlsZSBp dGVtcyA9IE5VTEw7CiAJaW50MzIJCXBjb3VudDsKIAlIU3RvcmUJICAgKm91dDsKIApAQCAt MTM5LDE0ICsxMzksMTMgQEAgcGxweXRob25fdG9faHN0b3JlKFBHX0ZVTkNUSU9OX0FSR1Mp CiAJCQkJIGVycm1zZygibm90IGEgUHl0aG9uIG1hcHBpbmciKSkpOwogCiAJcGNvdW50ID0g UHlNYXBwaW5nX1NpemUoZGljdCk7Ci0JaXRlbXNfdiA9IFB5TWFwcGluZ19JdGVtcyhkaWN0 KTsKKwlpdGVtcyA9IFB5TWFwcGluZ19JdGVtcyhkaWN0KTsKIAogCVBHX1RSWSgpOwogCXsK IAkJaW50MzIJCWJ1ZmxlbjsKIAkJaW50MzIJCWk7CiAJCVBhaXJzCSAgICpwYWlyczsKLQkJ UHlPYmplY3QgICAqaXRlbXMgPSAoUHlPYmplY3QgKikgaXRlbXNfdjsKIAogCQlwYWlycyA9 IHBhbGxvYyhwY291bnQgKiBzaXplb2YoKnBhaXJzKSk7CiAKQEAgLTE3NywxNCArMTc2LDE0 IEBAIHBscHl0aG9uX3RvX2hzdG9yZShQR19GVU5DVElPTl9BUkdTKQogCQkJCXBhaXJzW2ld LmlzbnVsbCA9IGZhbHNlOwogCQkJfQogCQl9Ci0JCVB5X0RFQ1JFRihpdGVtc192KTsKKwkJ UHlfREVDUkVGKGl0ZW1zKTsKIAogCQlwY291bnQgPSBoc3RvcmVVbmlxdWVQYWlycyhwYWly cywgcGNvdW50LCAmYnVmbGVuKTsKIAkJb3V0ID0gaHN0b3JlUGFpcnMocGFpcnMsIHBjb3Vu dCwgYnVmbGVuKTsKIAl9CiAJUEdfQ0FUQ0goKTsKIAl7Ci0JCVB5X0RFQ1JFRihpdGVtc192 KTsKKwkJUHlfREVDUkVGKGl0ZW1zKTsKIAkJUEdfUkVfVEhST1coKTsKIAl9CiAJUEdfRU5E X1RSWSgpOwpkaWZmIC0tZ2l0IGEvY29udHJpYi9qc29uYl9wbHB5dGhvbi9qc29uYl9wbHB5 dGhvbi5jIGIvY29udHJpYi9qc29uYl9wbHB5dGhvbi9qc29uYl9wbHB5dGhvbi5jCmluZGV4 IGY0NGQzNjRjOTcuLjFiYzk4NGQ1YzQgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIvanNvbmJfcGxw eXRob24vanNvbmJfcGxweXRob24uYworKysgYi9jb250cmliL2pzb25iX3BscHl0aG9uL2pz b25iX3BscHl0aG9uLmMKQEAgLTIzNywxNyArMjM3LDE0IEBAIFBMeU1hcHBpbmdfVG9Kc29u YlZhbHVlKFB5T2JqZWN0ICpvYmosIEpzb25iUGFyc2VTdGF0ZSAqKmpzb25iX3N0YXRlKQog CUpzb25iVmFsdWUgKm91dCA9IE5VTEw7CiAKIAkvKiBXZSBuZWVkIGl0IHZvbGF0aWxlLCBz aW5jZSB3ZSB1c2UgaXQgYWZ0ZXIgbG9uZ2ptcCAqLwotCXZvbGF0aWxlIFB5T2JqZWN0ICpp dGVtc192ID0gTlVMTDsKKwlQeU9iamVjdCAqdm9sYXRpbGUgaXRlbXMgPSBOVUxMOwogCiAJ cGNvdW50ID0gUHlNYXBwaW5nX1NpemUob2JqKTsKLQlpdGVtc192ID0gUHlNYXBwaW5nX0l0 ZW1zKG9iaik7CisJaXRlbXMgPSBQeU1hcHBpbmdfSXRlbXMob2JqKTsKIAogCVBHX1RSWSgp OwogCXsKIAkJUHlfc3NpemVfdAlpOwotCQlQeU9iamVjdCAgICppdGVtczsKLQotCQlpdGVt cyA9IChQeU9iamVjdCAqKSBpdGVtc192OwogCiAJCXB1c2hKc29uYlZhbHVlKGpzb25iX3N0 YXRlLCBXSkJfQkVHSU5fT0JKRUNULCBOVUxMKTsKIApAQCAtMjc5LDcgKzI3Niw3IEBAIFBM eU1hcHBpbmdfVG9Kc29uYlZhbHVlKFB5T2JqZWN0ICpvYmosIEpzb25iUGFyc2VTdGF0ZSAq Kmpzb25iX3N0YXRlKQogCX0KIAlQR19DQVRDSCgpOwogCXsKLQkJUHlfREVDUkVGKGl0ZW1z X3YpOworCQlQeV9ERUNSRUYoaXRlbXMpOwogCQlQR19SRV9USFJPVygpOwogCX0KIAlQR19F TkRfVFJZKCk7Ci0tIAoyLjIxLjAKCg== --------------776672112DE1B1A3AB88CC87--